New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [prefer-string-starts-ends-with] add allowSingleElementEquality option #8374
feat(eslint-plugin): [prefer-string-starts-ends-with] add allowSingleElementEquality option #8374
Conversation
…ElementEquality option
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8374 +/- ##
=======================================
Coverage 87.13% 87.14%
=======================================
Files 251 251
Lines 12269 12272 +3
Branches 3869 3871 +2
=======================================
+ Hits 10691 10694 +3
Misses 1306 1306
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🔥
packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md
Outdated
Show resolved
Hide resolved
…th.md Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
32d8a8f
into
typescript-eslint:main
PR Checklist
Overview
Adds a new
allowSingleElementEquality
option to the rule that's allowed to be'never'
(default) or'always'
.Doesn't yet add a third option for case matching as described in the issue. Is that ok to leave as a followup?
Also removes the auto-generation of tests from
prefer-string-starts-ends-with.test.ts
per #6887. The test file predates that preference.