Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add *-type-checked-only configs #8367

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds recommended-type-checked-only, strict-type-checked-only, and stylistic-type-checked-only configs, along with corresponding docs.

Also simplifies the writeExtendedConfig function a teeny bit, while I'm in the area.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f17a99b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65d60eb6c86f200008ae38fb
😎 Deploy Preview https://deploy-preview-8367--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Feb 4, 2024

@JoshuaKGoldberg
Copy link
Member Author

I'll wait to mark these changes as ok to merge until the flat config work lands. They can still be reviewed first though.

@JoshuaKGoldberg JoshuaKGoldberg added the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg removed the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f36f682) 86.94% compared to head (f17a99b) 87.74%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8367      +/-   ##
==========================================
+ Coverage   86.94%   87.74%   +0.80%     
==========================================
  Files         252      398     +146     
  Lines       12251    13827    +1576     
  Branches     3861     4067     +206     
==========================================
+ Hits        10652    12133    +1481     
- Misses       1332     1397      +65     
- Partials      267      297      +30     
Flag Coverage Δ
unittest 87.74% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 146 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg merged commit 13429cc into typescript-eslint:main Feb 22, 2024
61 of 63 checks passed
@me4502
Copy link

me4502 commented Feb 27, 2024

Is it intentional that these aren't visible from the index.ts file that the flat config documentation recommends (so we can't do ...tseslint.configs.recommendedTypeCheckedOnly)?

@JoshuaKGoldberg JoshuaKGoldberg deleted the type-checked-only-configs branch February 27, 2024 12:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configs: Provide configs that only have type-checked rules
3 participants