fix(eslint-plugin): [consistent-type-imports] handle imports without specifiers

[courageousillumination]

PR Checklist

• Addresses an existing open issue: fixes Bug: [consistent-type-imports] Attempts to fix the wrong import statement #7209
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Currently side effect imports will be marked as a valueOnlyNamedImport, which causes an error when trying insert the correct value import because it is expecting a }.

With these changes, we require that there is at least one specifier. If there is only a side effect import, a new import will be added with the specific value import.

One note is that this will also impact a named import with no specifiers import {} from 'foo'; Previously this would have inserted the value import into the empty {}; now it would insert it in a new import on a new line. I didn't see any way to distinguish between these two cases without looking for the braces explicitly; if that is not acceptable (since it changes how a fix is applied), please let me know and I can do the parsing.

This is my first PR against this repository, so please let me know if I missed anything 💖

[typescript-eslint]

Thanks for the PR, @courageousillumination!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	5a892c9
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65f4f1893ab51c0008e33e12
😎 Deploy Preview	https://deploy-preview-8308--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JoshuaKGoldberg]

An excellent start for a first PR! Great 💖 emoji choice too, noticed & appreciated. 😄

Requesting changes on adding a unit test (and rule logic if needed) for the extra case mentioned.

[JoshuaKGoldberg]

LGTM, thanks! Very clean & straightforward. Nice. 🙂

Adding 1 approval and requesting review from @bradzacher because it coincidentally intersects with #8335.

[bradzacher]

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5a892c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test eslint-plugin --coverage=false
• nx test utils
• nx test type-utils
• nx run types:build
• nx test typescript-eslint
• nx test typescript-estree
• nx test visitor-keys
• nx test rule-schema-to-typescript-types
• nx test scope-manager
• nx run repo-tools:postinstall-script
• nx test parser
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test eslint-plugin-internal
• nx test repo-tools
• nx test ast-spec
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx run-many --target=typecheck --parallel
• nx test typescript-eslint --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test type-utils --coverage=false
• nx test utils --coverage=false
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test visitor-keys --coverage=false
• nx test parser --coverage=false
• nx test scope-manager --coverage=false
• nx test ast-spec --coverage=false
• nx test repo-tools --coverage=false
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (609a000) to head (5a892c9).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8308      +/-   ##
==========================================
+ Coverage   87.23%   87.24%   +0.01%     
==========================================
  Files         251      251              
  Lines       12319    12319              
  Branches     3884     3884              
==========================================
+ Hits        10746    10748       +2     
+ Misses       1303     1302       -1     
+ Partials      270      269       -1     

Flag	Coverage Δ
unittest	87.24% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...eslint-plugin/src/rules/consistent-type-imports.ts	95.98% <ø> (+0.72%)	⬆️