fix(eslint-plugin): [prefer-readonly] disable checking accessors #8300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @Jamesernator! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JoshuaKGoldberg
requested changes
Jan 28, 2024
JoshuaKGoldberg
added
the
awaiting response
Jamesernator
changed the title
Jamesernator
changed the title
Jamesernator
changed the title
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
merged commit 4d2ce3b
into
typescript-eslint:main
53 of 55 checks passed
danvk
pushed a commit
to danvk/typescript-eslint
that referenced
this pull request
Feb 4, 2024
…escript-eslint#8300) * Disable checking accessors for prefer-readonly * Granular accessor tests * Update packages/eslint-plugin/src/rules/prefer-readonly.ts * fix: formatting and || for isModifierFlagSet suggestion --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Accessors don't support
readonly, so havingprefer-readonlyapply to them doesn't make sense. The current behaviour also generates an invalid fix, as such this PR simply removes accessors from being considered in the rule.