feat(eslint-plugin): [consistent-return] add new rule

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes [consistent-return] false positive when returning a void/undefined value #1277
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	b3ca34e
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65d77e43fd15740008215b6f
😎 Deploy Preview	https://deploy-preview-8289--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 89 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JoshuaKGoldberg]

+1 to @auvred's #8289 (comment) - looks like a blocking bug.

But otherwise this is looking snazzy, thanks for working on it! 🔥

[yeonjuan]

@StyleShit @auvred @JoshuaKGoldberg Thanks for the reviews, It's done!

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f825426) 86.89% compared to head (b3ca34e) 86.92%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8289      +/-   ##
==========================================
+ Coverage   86.89%   86.92%   +0.02%     
==========================================
  Files         250      251       +1     
  Lines       12201    12248      +47     
  Branches     3852     3864      +12     
==========================================
+ Hits        10602    10646      +44     
  Misses       1332     1332              
- Partials      267      270       +3     

Flag	Coverage Δ
unittest	86.92% <93.61%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts	50.00% <ø> (ø)
...kages/eslint-plugin/src/rules/consistent-return.ts	93.61% <93.61%> (ø)

[JoshuaKGoldberg]

Swell!

Looks like auvred is doing a good job reviewing, so I just commented in a few places. Good stuff so far!

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b3ca34e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test typescript-eslint
• nx run types:build
• nx test type-utils
• nx test typescript-estree
• nx test visitor-keys
• nx test scope-manager
• nx test utils
• nx test eslint-plugin --coverage=false
• nx run repo-tools:postinstall-script
• nx test repo-tools
• nx test rule-schema-to-typescript-types
• nx run-many --target=lint --parallel
• nx test parser
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test eslint-plugin-internal
• nx test ast-spec
• nx run-many --target=typecheck --parallel
• nx test utils --coverage=false
• nx test visitor-keys --coverage=false
• nx test scope-manager --coverage=false
• nx run integration-tests:test
• nx run repo-tools:generate-configs
• nx test typescript-eslint --coverage=false
• nx test ast-spec --coverage=false
• nx test type-utils --coverage=false
• nx test repo-tools --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test parser --coverage=false
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal --coverage=false

---

Sent with 💌 from NxCloud.

[auvred]

[JoshuaKGoldberg]