fix(eslint-plugin): [member-ordering] report alphabetical sorting for all groups instead of just the first failing group

[arka1002]

PR Checklist

• Addresses an existing open issue: fixes [member-ordering] report alphabetical sorting for all groups instead of just the first failing group #8100
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

1. Previously, if a group of MemberType was unsorted, then it was reported ignoring the rest of the MemberTypes, now all of them are reported.
2. Previously, if the MemberTypes weren't in order wrt config, alphabetic sort was avoided, now both takes place.

[typescript-eslint]

Thanks for the PR, @arka1002!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

Name	Link
🔨 Latest commit	86af17b
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65e0ab074770a900080f42d5

[JoshuaKGoldberg]

Seems reasonable on a read-through, but I'm having a hard time understanding the added code. Which means future folks with less context would probably have a harder time. What do you think about the clarification + cleanup comments?

Btw, emphasizing from a comment: this rule is inherently pretty tricky and complex. So I think any changes will be that way too. Nice job getting it to work! 👏

[JoshuaKGoldberg]

fixes: #8100

PR Checklist

...

Btw, no need to put the fixes: #... on top of the PR description. It's in the checklist. 🙂

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 86af17b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test typescript-estree
• nx run types:build
• nx test type-utils
• nx test parser
• nx test repo-tools
• nx run repo-tools:postinstall-script
• nx test eslint-plugin --coverage=false
• nx test scope-manager
• nx test utils
• nx test visitor-keys
• nx test typescript-eslint
• nx test rule-schema-to-typescript-types
• nx test scope-manager --coverage=false
• nx test ast-spec --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test ast-spec
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test visitor-keys --coverage=false
• nx run-many --target=typecheck --parallel
• nx test utils --coverage=false
• nx test type-utils --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run integration-tests:test
• nx test typescript-eslint --coverage=false
• nx test parser --coverage=false
• nx test repo-tools --coverage=false
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

⚡ this is looking really snazzy! I'm happy with how it's coming along, and think I understand it a lot better now thanks to the new structures & comments.

Mostly requesting changes on some small touchups. I think this is getting pretty close to merge-ready!

[JoshuaKGoldberg]

[Performance] Why waste time run lot iteration when few do trick?

Suggested change

	return grouped
	.map(groupMember =>
	checkAlphaSort(groupMember, order as AlphabeticalOrder),
	)
	.some(result => !result);
	return grouped.some(
	groupMember =>
	!checkAlphaSort(groupMember, order as AlphabeticalOrder),
	);

More helpfully: .map does a loop over everything in grouped, then .some bails out as soon as a result is found. So we can combine the two into one to bail out early if possible.

[arka1002]

Yeah, using .some is a part of the problem of the issue. Currently before this pr, the rule only run alphabetical sort on a particular group, if that group was sorted, then only it checked the next group(which is the early bailing out due to .some), else the next group remains unchecked.

An example test - https://github.com/typescript-eslint/typescript-eslint/pull/8263/files#diff-28e99227546efaad4ed38d47dcd8746943b60b09b2095a68ec4209856d709e1fR128-R129

But yeah, I removed .some, I think it isn't necessary.

[JoshuaKGoldberg]

🙌 Whoop! This looks wonderful - thanks for working with me on it.

Since I've looked at it so much, I'll leave it open as 1 approval in the hopes another team member can get to it.

[auvred]

The changes looks great! 🚀

[flohw]

Just updated and tested. This is a huge improvement to have all the errors at once.

Thank you again for the fix and reviews! 🙂