Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [prefer-nullish-coalescing] treat any/unknown as non-nullable #8262

Merged
merged 3 commits into from
Jan 28, 2024
Merged

fix(eslint-plugin): [prefer-nullish-coalescing] treat any/unknown as non-nullable #8262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa7c806
fix(eslint-plugin): [prefer-nullish-coalescing] treat any/unknown as …
auvred Jan 16, 2024
56a1ea2
chore: rm unrelated changes
auvred Jan 16, 2024
ce3d8e0
test: add declarations of 'y' variable
auvred Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dacarley threading #8262 (comment):

Has anyone confirmed that this change fixes #8261 and #8276? If not, I may try to confirm it tomorrow.

If confirmed, can the final question about nullish coalescing be deferred into a new PR?

Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import {
getTypeFlags,
isLogicalOrOperator,
isNodeEqual,
isNullableType,
isNullLiteral,
isTypeFlagSet,
isUndefinedIdentifier,
nullThrows,
NullThrowsReasons,
Expand Down Expand Up @@ -309,7 +309,7 @@ export default createRule<Options, MessageIds>({
): void {
const tsNode = parserServices.esTreeNodeToTSNodeMap.get(node);
const type = checker.getTypeAtLocation(tsNode.left);
if (!isNullableType(type)) {
if (!isTypeFlagSet(type, ts.TypeFlags.Null | ts.TypeFlags.Undefined)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Josh-Cena threading #8262 (comment):

I'm good with this solution 👍 I wonder though, shouldn't we recommend switching to nullish coalescing for any/unknown too, with an option to turn that off, just like primitives? Because any/unknown are also nullable, it doesn't make no sense to use nullish coalescing.

Hmm, good question. I think if the type is explicitly not known then it'd be risky to suggest making any concrete changes to its handling. I'd be in support of this as an opt-in in for v6 and maybe an opt-out for v7.

return;
}

Expand Down
15 changes: 15 additions & 0 deletions packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,21 @@ x || y;
`,
options: [{ ignorePrimitives: true }],
})),
`
declare const x: any;
declare const y: number;
x || y;
`,
`
declare const x: unknown;
declare const y: number;
x || y;
`,
`
declare const x: never;
declare const y: number;
x || y;
`,
auvred marked this conversation as resolved.
Show resolved Hide resolved
],
invalid: [
...nullishTypeInvalidTest((nullish, type) => ({
Expand Down