Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [member-ordering] allow easy reuse of the default ordering #8248

Merged
merged 4 commits into from Jan 28, 2024

Conversation

parloti
Copy link
Contributor

@parloti parloti commented Jan 14, 2024

PR Checklist

Overview

This PR allows to customize the member-ordering rule, while maintaining the default member groups without having to copy and paste more than 100 lines of code.
The PR changes the way that the default settings is specified by causing these to be merged with the custom settings rather than replaced.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @parloti!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 445be6f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65acebfeae12690008578336
😎 Deploy Preview https://deploy-preview-8248--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradzacher bradzacher added the bug Something isn't working label Jan 28, 2024
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): member-ordering default configuration feat(eslint-plugin): allow reuse of the default ordering without having to copy it Jan 28, 2024
@bradzacher bradzacher added enhancement New feature or request and removed bug Something isn't working labels Jan 28, 2024
@bradzacher bradzacher changed the title feat(eslint-plugin): allow reuse of the default ordering without having to copy it feat(eslint-plugin): [member-ordering] allow easy reuse of the default ordering Jan 28, 2024
@bradzacher bradzacher merged commit bbc6770 into typescript-eslint:main Jan 28, 2024
59 checks passed
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: member-ordering default configuration
2 participants