fix(type-utils): preventing isUnsafeAssignment infinite recursive calls

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-unsafe-argument] Maximum call stack size exceeded for recursive types #7298, fixes Bug: [no-unsafe-argument] stackoverflow crash when using recursive types #5014
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

This PR prevents infinite recursive calls to isUnsafeAssignment for code with circular references.

no-unsafe-argument ( #7298, #5014)

playground

type T = [number, T[]];
declare function foo(t: T): void;
declare const t: T;

foo(t);

RangeError: Maximum call stack size exceeded
...

no-unsafe-assignment (unreported issue)

playground

type T = [string, T[]];
const test: T = ['string', []] as T;

RangeError: Maximum call stack size exceeded
..

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	a84ed04
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65a5361bdc580f0007a82cbb
😎 Deploy Preview	https://deploy-preview-8237--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 89 (🔴 down 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JoshuaKGoldberg]

LGTM, thanks for the double-fix! 🚀 🚀

Just suggesting changes for the one refactor. If I missed something on it then no worries we can ship as-is.

[JoshuaKGoldberg]

[Refactor] This code works great as-is, but has a couple of little paper cuts IMO:

• Each call now has to check whether visited exists (this is not really a big issue at all, certainly not a blocker)
• Callers now can see this visited Map even though there's no reason for them to provide it

What do you think about making a non-exported worker function so the public signature doesn't need to have visited?

  senderNode: TSESTree.Node | null,
): false | { sender: ts.Type; receiver: ts.Type } {
  return isUnsafeAssignmentWorker(type, receiver, checker, senderNode, new Map());

[yeonjuan]

What do you think about making a non-exported worker function so the public signature doesn't need to have visited?

I think it's much better. let me refactor it! :)

[JoshuaKGoldberg]