Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix invalid parsing error when use update expression on non-null assertion #8202

Merged

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Jan 6, 2024

PR Checklist

Overview

I tried to report this issue, but the same issue was already created. #8201 doesn't have an accepting PRS label yet, but I'm raising a PR because I think it's definitely a bug and I want it fixed quickly.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4b27faa
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/659981854e6619000852012f
😎 Deploy Preview https://deploy-preview-8202--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4fdce89 into typescript-eslint:main Jan 6, 2024
56 of 58 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 6.18.0 breaks when parsing foo!--
2 participants