fix(eslint-plugin): [no-non-null-assertion] provide valid fix when member access is on next line

[auvred]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-non-null-assertion] Fix puts ? on wrong line when member access is on next line #8179
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

I took the opportunity to do a little refactoring (and improve test coverage):

• get non-null assertion operator once (and assert that it is not nullable)
• convertTokenToOptional -> replaceTokenWithOptional only replaces ! with ?.
• replace ! with ? directly in the suggestion, since this case is unique

[typescript-eslint]

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	529e99e
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/659b8adfc943960008e1c846
😎 Deploy Preview	https://deploy-preview-8185--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🔴 down 9 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JoshuaKGoldberg]

And even the comments 😁 thanks, great work!