fix(eslint-plugin): [prefer-readonly] support modifiers of unions and intersections #8169
Conversation
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| if (type.isUnion()) { | ||
| // any union of class/instance and something else will prevent access to | ||
| // private members, so we assume that union consists only of classes | ||
| // or class instances, because otherwise tsc will report an error | ||
| return this.getTypeToClassRelation(type.types[0]); | ||
| } |
There was a problem hiding this comment.
class Test {
private foo: number = 1
private static foo: number
test() {
const that1 = {} as typeof Test | this
that1.foo = 2
// ^ 2339: Property 'foo' does not exist on type 'this | typeof Test'
const that2 = {} as this | { _foo: 'bar' }
that2.foo = 2
// ^ 2339: Property 'foo' does not exist on type 'this | { _foo: "bar"; }'
const that3 = {} as typeof Test | { _foo: 'bar' }
that3.foo = 2
// ^ 2339: Property 'foo' does not exist on type 'typeof Test | { _foo: "bar"; }'
}
}
| @@ -251,6 +251,13 @@ type ParameterOrPropertyDeclaration = | |||
| const OUTSIDE_CONSTRUCTOR = -1; | |||
| const DIRECTLY_INSIDE_CONSTRUCTOR = 0; | |||
|
|
|||
| enum TypeToClassRelation { | |||
There was a problem hiding this comment.
[Praise] I found this enum and the logic around it to be quite helpful in understanding the new logic. Very readable. Nice! 👏
JoshuaKGoldberg
merged commit 3a219c0
into
typescript-eslint:main
PR Checklist
Overview