Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): improve error message on typed rule with invalid parser #8146

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 27, 2023

PR Checklist

Overview

Adds a small regex in getParserServices to catch common cases of incorrect parsers. It's not comprehensive (../parser.js unfortunately passes) but it does catch the common case of node_modules/@babel/*.

Note that this only augments the existing error message. It doesn't add any new error catching / situations where getParserServices would throw.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 649917f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6599fbb18071ba0008542e55
😎 Deploy Preview https://deploy-preview-8146--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat(utils): throw error on typed rule with invalid parser feat(utils): improve error message on typed rule with invalid parser Dec 28, 2023
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 28, 2023 20:33
@bradzacher
Copy link
Member

Note: probably class this as a fix for semver purposes

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat(utils): improve error message on typed rule with invalid parser fix(utils): improve error message on typed rule with invalid parser Jan 7, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 687f73c into typescript-eslint:main Jan 7, 2024
58 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the utils-assert-our-parser branch January 7, 2024 16:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: getParserServices should throw informative error when used with non-typescript-eslint parser
2 participants