Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: blog post on parserOptions.projectService #8031
base: main
Are you sure you want to change the base?
docs: blog post on parserOptions.projectService #8031
Changes from 1 commit
be19629
105a406
a107204
31cbb5d
c0b6d90
17fd25f
a7097ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
babel/babel#16192 ❤️ - would be nice to have a "success stories" section...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞 hopefully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh if we don't support flat config by the time this rolls out I will be in a lot of emotional pain...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: before un-drafting, I"ll want to revisit this and align it to how our flat config support ended up looking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__dirname
is not available inside an NodeJS ES Module.Use
import.meta.dirname
(since v21.2.0) orjoin(fileURLToPath(import.meta.url), '..')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't like this advice because it's a lot wider than we might otherwise intend and will match all files in the root.
I think it's better to not suggest
./*
and instead suggest being explicit to keep things narrow and cleaner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blurgh, I'm torn. It's rather inconvenient having to specify files by name. It's pretty common to have >=3 files there. https://github.com/JoshuaKGoldberg/create-typescript-app has ESLint, tsup, and Vitest right now.
Having a
['./*']
be the starting recommending means users can copy+paste without having to pause to tinker with individual file names. IMO the much smoother onboarding there is a pretty big value prop.Given that #7752 has it throw an error if a file is redundantly included, what are the practical downsides of having a permissive glob?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for before landing - this doesn't exist yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also good to have - #7906 ...