Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn version not specified in monorepo #7371

Merged
merged 12 commits into from Jul 31, 2023
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -144,5 +144,6 @@
"pretty-format": "^29",
"tsx": "^3.12.7",
"typescript": "5.1.6"
}
},
"packageManager": "yarn@1.22.19"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesHenry fyi as #6162 is upcoming

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that shouldn't really affect this pr

}
Expand Up @@ -63,7 +63,7 @@ As a result, we've reworked the configurations provided by typescript-eslint int

- Functional rule configurations, for best best practices and code correctness:
- **`recommended`**: Recommended rules that you can drop in without additional configuration.
- **`recommended-type-checked`**: Additional recommended rules that require type information.
- **`recommended-type-checked`**: Additional recommended rules that require type information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the deal with this diff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, it showed up as different when I copy pasted the md file from the main branch. are they different kind of spaces or something? I tried copy pasting them into this site and they both show up as normal spaces, so I'm not really sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git checkout main -- packages/website/blog/2023-07-09-announcing-typescript-eslint-v6.md fixed it for me. 🤷

- **`strict`**: Additional strict rules that can also catch bugs but are more opinionated than recommended rules _(without type information)_.
- **`strict-type-checked`**: Additional strict rules that do require type information.
- Stylistic rule configurations, for consistent and predictable syntax usage:
Expand Down