Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scope-manager): correct decorators(.length) check in ClassVisitor for methods #7334

Merged
merged 3 commits into from Jul 29, 2023
Merged

fix(scope-manager): correct decorators(.length) check in ClassVisitor for methods #7334

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
511b6f4
fix(scope-manager): correct decorators(.length) check in ClassVisitor…
JoshuaKGoldberg Jul 27, 2023
d92dd0b
Aha, a missing unit test
JoshuaKGoldberg Jul 28, 2023
2b8ed41
Merge branch 'main' into class-visitor-method-decorators-check
JoshuaKGoldberg Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/scope-manager/src/referencer/ClassVisitor.ts
View file
Open in desktop
Expand Up @@ -192,7 +192,7 @@ class ClassVisitor extends Visitor {
if (
!withMethodDecorators &&
methodNode.kind === 'constructor' &&
this.#classNode.decorators
this.#classNode.decorators.length
) {
withMethodDecorators = true;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/scope-manager/tests/fixtures/class/emit-metadata/nested-class-inner.ts.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/scope-manager/tests/fixtures/class/emit-metadata/nested-class-outer.ts.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.