Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): remove swc: true to fix builds #7167

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 6, 2023

PR Checklist

Overview

Stops using swc: true in ts-node so that the website will build again.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 718a4ca
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64a73a57bc979c0008c3bb5c
😎 Deploy Preview https://deploy-preview-7167--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Josh-Cena
Copy link
Member

I'm quite baffled by this as well. I'll take a look later.

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, the number of weirdities SWC has makes this really hard to debug. Do you think it's better to try adding an .swcrc file? Or we can just get rid of SWC like this—it's only one config file, no big deal.

@rubiesonthesky
Copy link
Contributor

I have other PR for this problem #7182 - let's see if the build succeeds with that change :)

@JoshuaKGoldberg
Copy link
Member Author

Oop, I did this in v6 which is now merged to main. So this PR is redundant.

@JoshuaKGoldberg JoshuaKGoldberg deleted the website-fix-docusaurus-swc branch July 13, 2023 15:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Docusaurus builds are broken on main
3 participants