Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [ban-types] ban types in extends and implements #7129

Merged
merged 4 commits into from Jun 28, 2023
Merged

feat(eslint-plugin): [ban-types] ban types in extends and implements #7129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e18dc9
test(eslint-plugin): add test for banning types when using intersections
Haberkamp Jun 22, 2023
59050af
feat(eslint-plugin): ban certain types to be extended from
Haberkamp Jun 22, 2023
571395d
Merge branch 'main' into ban-certain-types-to-be-extended-from
Haberkamp Jun 24, 2023
9f6dfa8
Merge branch 'main' into ban-certain-types-to-be-extended-from
Haberkamp Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/eslint-plugin/src/rules/ban-types.ts
View file
Open in desktop
Expand Up @@ -260,6 +260,12 @@ export default util.createRule<Options, MessageIds>({
checkBannedTypes(node);
}
},
TSInterfaceHeritage(node): void {
checkBannedTypes(node);
},
TSClassImplements(node): void {
checkBannedTypes(node);
},
};
},
});
75 changes: 75 additions & 0 deletions packages/eslint-plugin/tests/rules/ban-types.test.ts
View file
Open in desktop
Expand Up @@ -657,6 +657,81 @@ let baz: object = {};
},
],
},
{
code: 'type Baz = 1 & Foo;',
errors: [
{
messageId: 'bannedTypeMessage',
},
],
options: [
{
types: {
Foo: { message: '' },
},
},
],
},
{
code: 'interface Foo extends Bar {}',
errors: [
{
messageId: 'bannedTypeMessage',
},
],
options: [
{
types: {
Bar: { message: '' },
},
},
],
},
{
code: 'interface Foo extends Bar, Baz {}',
errors: [
{
messageId: 'bannedTypeMessage',
},
],
options: [
{
types: {
Bar: { message: '' },
},
},
],
},
{
code: 'class Foo implements Bar {}',
errors: [
{
messageId: 'bannedTypeMessage',
},
],
options: [
{
types: {
Bar: { message: '' },
},
},
],
},
{
code: 'class Foo implements Bar, Baz {}',
errors: [
{
messageId: 'bannedTypeMessage',
},
],
options: [
{
types: {
Bar: { message: 'Bla' },
},
},
],
},
...objectReduceKey(
TYPE_KEYWORDS,
(acc: TSESLint.InvalidTestCase<MessageIds, Options>[], key) => {
Expand Down