Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): add new extended rule prefer-destructuring #7117

Merged
merged 41 commits into from
Oct 11, 2023
Merged

feat(eslint-plugin): add new extended rule prefer-destructuring #7117

merged 41 commits into from
Oct 11, 2023
+1,518 −0

Commits on Jun 10, 2023

  1. copy prefer-destructuring from ESLint

    @seiyab
    seiyab committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    8e328f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. rewrite schema by hand

    @seiyab
    seiyab committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    392f132 View commit details
    Browse the repository at this point in the history

  2. add enforceForTypeAnnotatedProperties option 

    autofix is still wrong.
    @seiyab
    seiyab committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4435c44 View commit details
    Browse the repository at this point in the history

  3. add tests

    @seiyab
    seiyab committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    e5ab24f View commit details
    Browse the repository at this point in the history

  4. prevent fixing type-annotated declaration

    @seiyab
    seiyab committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    90e094f View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. add tests

    @seiyab
    seiyab committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1619def View commit details
    Browse the repository at this point in the history

  2. move baseTests into end of file

    @seiyab
    seiyab committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8bcb921 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. refactor

    @seiyab
    seiyab committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    47b9e6c View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2023

  1. consider numeric properties of non-itreable objects for VariableDecla… 

    …rator
    @seiyab
    seiyab committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    e997503 View commit details
    Browse the repository at this point in the history

  2. consider numeric properties of non-itreable objects for AssignmentEx… 

    …pression
    @seiyab
    seiyab committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    375f99c View commit details
    Browse the repository at this point in the history

  3. fix a bug

    @seiyab
    seiyab committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    05680aa View commit details
    Browse the repository at this point in the history

  4. fix a bug

    @seiyab
    seiyab committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    a687993 View commit details
    Browse the repository at this point in the history

  5. add "openjsf" into the dictionary

    @seiyab
    seiyab committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    0fbc758 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. add prefer-destructuring into all

    @seiyab
    seiyab committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7951154 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. add doc and minor tweak

    @seiyab
    seiyab committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d3626c6 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @seiyab
    seiyab committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    93c179c View commit details
    Browse the repository at this point in the history

  3. fix incorrect "correct" case

    @seiyab
    seiyab committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5ebadbf View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. improve test coverage

    @seiyab
    seiyab committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5d1e5be View commit details
    Browse the repository at this point in the history

  2. improve test coverage

    @seiyab
    seiyab committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    2d7e2af View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into prefer-destructuring

    @seiyab
    seiyab committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7199034 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Merge branch 'main' into prefer-destructuring

    @seiyab
    seiyab committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    854f1c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Merge branch 'main' into prefer-destructuring

    @seiyab
    seiyab committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2b92380 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. Merge branch 'main' into prefer-destructuring

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    2b4fdc1 View commit details
    Browse the repository at this point in the history

  2. fix: bring in adjustments from main branch

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    521506c View commit details
    Browse the repository at this point in the history

  3. Updated snapshot

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    044d503 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Update packages/eslint-plugin/src/rules/prefer-destructuring.ts 

    Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
    @seiyab @JoshuaKGoldberg
    seiyab and JoshuaKGoldberg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    0102f80 View commit details
    Browse the repository at this point in the history

  2. rename a function

    @seiyab
    seiyab committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b6a1840 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. fix typo

    @seiyab
    seiyab committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4d69749 View commit details
    Browse the repository at this point in the history

  2. reduce baseRule.create() calls

    @seiyab
    seiyab committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b2de45b View commit details
    Browse the repository at this point in the history

  3. lazily run baseRule.create(noFixContext(context))

    @seiyab
    seiyab committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c0dbe8f View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. lint

    @seiyab
    seiyab committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7e0d976 View commit details
    Browse the repository at this point in the history

  2. add test cases

    @seiyab
    seiyab committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    a1e24e4 View commit details
    Browse the repository at this point in the history

  3. add test cases

    @seiyab
    seiyab committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    67a18bc View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'main' into prefer-destructuring

    @seiyab
    seiyab committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6b4bebe View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. remove tests copied from base rule

    @seiyab
    seiyab committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    96cbada View commit details
    Browse the repository at this point in the history

  2. add tests

    @seiyab
    seiyab committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4ca0e2a View commit details
    Browse the repository at this point in the history

  3. add tests

    @seiyab
    seiyab committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    25f780d View commit details
    Browse the repository at this point in the history

  4. declare variables

    @seiyab
    seiyab committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7451956 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. minor improvements 

    - naming of options
- using nullish coalescing assignment
    @seiyab
    seiyab committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    6ca18e1 View commit details
    Browse the repository at this point in the history

  2. improve type and coverage

    @seiyab
    seiyab committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3c23be8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into prefer-destructuring

    @seiyab
    seiyab committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    77b6704 View commit details
    Browse the repository at this point in the history