Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for node v14 and test against node v20 #7022

Merged
merged 3 commits into from May 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -11,7 +11,7 @@ on:
merge_group:

env:
PRIMARY_NODE_VERSION: 18
PRIMARY_NODE_VERSION: 20
# Only set the read-write token if we are on the main branch
NX_CLOUD_ACCESS_TOKEN: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') && secrets.NX_CLOUD_ACCESS_TOKEN || '' }}

Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
strategy:
matrix:
# just run on the oldest and latest supported versions and assume the intermediate versions are good
node-version: [14, 18]
node-version: [16, 20]
package:
[
'ast-spec',
Expand Down
2 changes: 1 addition & 1 deletion docs/linting/Typed_Linting.mdx
Expand Up @@ -34,7 +34,7 @@ See [our TSConfig inclusion FAQ](./Troubleshooting.mdx#i-get-errors-telling-me-e

In more detail:

- `plugin:@typescript-eslint/recommended-type-checked` is another [recommended configuration](./CONFIGURATIONS.mdx) we provide. This one contains recommended rules that additionally require type information.
- `plugin:@typescript-eslint/recommended-type-checked` is another [recommended configuration](./Configurations.mdx) we provide. This one contains recommended rules that additionally require type information.
- `parserOptions.project` tells our parser how to find the TSConfig for each source file (`true` indicates to find the closest `tsconfig.json` for each source file)
- If your project is a multi-package monorepo, see [our docs on configuring a monorepo](./typed-linting/Monorepos.mdx).
- `parserOptions.tsconfigRootDir` tells our parser the absolute path of your project's root directory (see [Parser#tsconfigRootDir](../architecture/Parser.mdx#tsconfigRootDir)).
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -50,7 +50,7 @@
"typecheck": "nx run-many --target=typecheck --parallel"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"devDependencies": {
"@babel/code-frame": "^7.21.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/ast-spec/package.json
Expand Up @@ -9,7 +9,7 @@
"estree"
],
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"files": [
"dist",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-tslint/package.json
Expand Up @@ -19,7 +19,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/package.json
Expand Up @@ -23,7 +23,7 @@
}
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/parser/package.json
Expand Up @@ -17,7 +17,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/rule-schema-to-typescript-types/package.json
Expand Up @@ -11,7 +11,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/rule-tester/package.json
Expand Up @@ -17,7 +17,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/scope-manager/package.json
Expand Up @@ -17,7 +17,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/type-utils/package.json
Expand Up @@ -18,7 +18,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/types/package.json
Expand Up @@ -18,7 +18,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/typescript-estree/package.json
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/package.json
Expand Up @@ -38,7 +38,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/visitor-keys/package.json
Expand Up @@ -18,7 +18,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/website-eslint/package.json
Expand Up @@ -14,7 +14,7 @@
}
},
"engines": {
"node": "^14.18.0 || ^16.0.0 || >=18.0.0"
"node": "^16.0.0 || >=18.0.0"
},
"scripts": {
"build": "yarn tsx ./build.ts",
Expand Down
Expand Up @@ -162,6 +162,7 @@ Several rules were changed in significant enough ways to be considered breaking

- [feat(typescript-estree): deprecate createDefaultProgram](https://github.com/typescript-eslint/typescript-eslint/pull/5890): Renames `createDefaultProgram` to `deprecated__createDefaultProgram`, with associated `@deprecated` TSDoc tags and warnings.
- [feat: drop support for node v12](https://github.com/typescript-eslint/typescript-eslint/pull/5918)
- [feat: drop support for node v14](https://github.com/typescript-eslint/typescript-eslint/pull/7022)
- [feat: bump minimum supported TS version to 4.3.5](https://github.com/typescript-eslint/typescript-eslint/issues/6923): this matches [DefinitelyTyped's 2-year support window](https://github.com/DefinitelyTyped/DefinitelyTyped#support-window).
- [chore: drop support for ESLint v6](https://github.com/typescript-eslint/typescript-eslint/pull/5972)
- [feat(eslint-plugin): [prefer-readonly-parameter-types] added an optional type allowlist](https://github.com/typescript-eslint/typescript-eslint/pull/4436): changes the public `isTypeReadonlyArrayOrTuple` function's first argument from a `checker: ts.TypeChecker` to a full `program: ts.Program`
Expand Down