feat(typescript-estree): check modifiers on every node

[fisker]

PR Checklist

• Addresses an existing open issue: fixes #000
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

I copied those checks from Prettier repo, they are originally copied from typescript package.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0de70f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 29 targets

• nx run-many --target=lint --parallel
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run integration-tests:test
• nx run-many --target=typecheck --parallel
• Node 14 - nx test repo-tools --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx test ast-spec --coverage=false
• Node 18 - nx test ast-spec
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx test parser --coverage=false
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 18 - nx test parser
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	5e7050b
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64124f810163f80008466c74
😎 Deploy Preview	https://deploy-preview-6615--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #6615 (1c617a1) into v6 (957bdcb) will increase coverage by 1.57%.
The diff coverage is 15.25%.

❗ Current head 1c617a1 differs from pull request most recent head 5e7050b. Consider uploading reports for the commit 5e7050b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #6615      +/-   ##
==========================================
+ Coverage   85.52%   87.09%   +1.57%     
==========================================
  Files         372      365       -7     
  Lines       12694    12545     -149     
  Branches     3754     3724      -30     
==========================================
+ Hits        10856    10926      +70     
+ Misses       1480     1237     -243     
- Partials      358      382      +24     

Flag	Coverage Δ
unittest	87.09% <15.25%> (+1.57%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/node-utils.ts	61.76% <0.00%> (-0.86%)	⬇️
packages/typescript-estree/src/convert.ts	29.89% <17.64%> (-1.88%)	⬇️

... and 28 files with indirect coverage changes

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5e7050b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 30 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• nx run-many --target=build --projects=website-eslint,website
• Node 18 - nx test typescript-estree
• nx run-many --target=lint --parallel
• Node 18 - nx test type-utils
• Node 18 - nx test parser
• Node 18 - nx test scope-manager
• Node 18 - nx run types:build
• Node 18 - nx test visitor-keys
• Node 18 - nx test utils
• Node 18 - nx test eslint-plugin-tslint
• Node 18 - nx test repo-tools
• Node 14 - nx test typescript-estree --coverage=false
• Node 18 - nx test eslint-plugin-internal
• Node 18 - nx test ast-spec
• Node 14 - nx test type-utils --coverage=false
• nx run-many --target=typecheck --parallel
• Node 14 - nx test utils --coverage=false
• Node 14 - nx run types:build
• nx run integration-tests:test
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx test parser --coverage=false
• nx run types:build
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx test repo-tools --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[bradzacher]

LGTM! THanks!