Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: remove experimental-utils" #6602

Closed
wants to merge 1 commit into from

Conversation

JoshuaKGoldberg
Copy link
Member

Reverts #6468

Discussed privately - letting the changes in #6179 live for a little while.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Mar 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c13670. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 51 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Mar 11, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1c13670
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/640d0ace82ea1c000803036b
😎 Deploy Preview https://deploy-preview-6602--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher
Copy link
Member

just to revisit this and have a chat in the open.

utils was officially released in 5.10.0 (18/1/2022 - 419 days ago) at which point we officially (but silently) deprecated experimental-utils.

#6179 (which causes a console log) on usage will create noise for consumers that have experimental-utils as a transient dependency, which isn't a great UX.

The two options we have are:

  • explicitly npm deprecate experimental-utils and hard-lock it as a <v6 package
  • release experimental-utils with the console logs and v6, and create some noise for the user (to hopefully help drive migrations), and then officially drop it with v7.

Personally I think the former is better because (a) the deprecation message is install-time-only, so it won't spam users' lint runs and (b) hard-locking to v5 means packages can't be lazy - they have to migrate to keep updated.

I'd love to hear your thoughts again Josh, maybe @typescript-eslint/triage-team has some thoughts as well?

@JoshuaKGoldberg
Copy link
Member Author

FWIW this isn't a strong feeling on my end - I'm happy going along with either.

Part of why I was excited about going with #6179's console log is that @kball got to contribute, and I didn't want that contribution to end up going nowhere. But if (a) is the better case instead, that works too.

@JoshuaKGoldberg
Copy link
Member Author

(closing for now since it seems this PR isn't particularly popular 😄)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants