test(ast-spec): snapshot codeframe of error

[fisker]

PR Checklist

• Addresses an existing open issue: fixes #000
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

During upgrade parser to v6 in Prettier, I found some error location should be improved, but before that, let's make the error visible?

[nx-cloud]

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 33a4fec.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	33a4fec
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64001902a7308b000802f101
😎 Deploy Preview	https://deploy-preview-6555--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[bradzacher]

this is a great idea!
I wonder if we should be capturing an end as well as part of the TSError?

That way we could throw errors on ranges instead of just on single characters.
Looks like code-frame also supports an end range, so we would even be able to snapshot it.

WDYT?

[fisker]

I wonder if we should be capturing an end as well as part of the TSError?

Prettier throws errors include a start and an end, see this diff.
I hope to merge this one first, and change the errors to add more information later.

[fisker]

@bradzacher Don't know how to fix this, can you help?

[bradzacher]

oops - i didn't see the error before merging 🤦

[bradzacher]

Should be fixed by f98afd2