Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bumped ts-api-utils to 0.0.39 #6497

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 20, 2023

PR Checklist

Overview

Pulls in ts-api-utils@0.0.28, which includes:

Also renames the imported names from tools to tsutils per the package's updated docs.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 20, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c65ac02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 51 targets

Sent with 💌 from NxCloud.

interface Obj2 {
readonly [K: string]: Obj1;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was done by my editor. 🤷 might as well.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Feb 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 21, 2023
@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c65ac02
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63f6b4cec4bec70008723db3
😎 Deploy Preview https://deploy-preview-6497--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix: bumped ts-api-utils to 0.0.28 fix: bumped ts-api-utils to 0.0.39 Feb 23, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit 217c710 into typescript-eslint:v6 Feb 23, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the ts-api-utils-0.0.28 branch February 23, 2023 03:58
@@ -10,4 +10,4 @@ index 41ee37c..e4279d1 100644
+ "type": "commonjs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically we shouldn't need this patch any more if the package now correctly exports the cjs types

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants