New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup repo lint + typechecking #6473
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes here that look good - but the tests are borked?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #6473 +/- ##
=======================================
Coverage 87.12% 87.12%
=======================================
Files 362 362
Lines 12473 12474 +1
Branches 3688 3688
=======================================
+ Hits 10867 10868 +1
Misses 1260 1260
Partials 346 346
Flags with carried forward coverage won't be shown. Click here to find out more.
|
editFunc(contents), | ||
].join('\n'), | ||
'utf8', | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 +1, was going to ask for something like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
I noticed a lot of missing coverage with our linting and typechecking setup.
.js
files weren't being linted or formatted around the place.d.ts
files weren't being linted or formattedIn some cases files were just part of ignore files when they shouldn't've been.
In other cases they weren't properly covered by the nx command config.
This PR fixes all of that with a small reorganisation of the codebase and addition of some config files. It also upgrades prettier.