Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup repo lint + typechecking #6473

Merged
merged 7 commits into from Feb 16, 2023
Merged

chore: cleanup repo lint + typechecking #6473

merged 7 commits into from Feb 16, 2023

Conversation

bradzacher
Copy link
Member

I noticed a lot of missing coverage with our linting and typechecking setup.

  • The top-level test and tools directories weren't being linted/typechecked
  • .js files weren't being linted or formatted around the place
  • Some of our .d.ts files weren't being linted or formatted

In some cases files were just part of ignore files when they shouldn't've been.
In other cases they weren't properly covered by the nx command config.

This PR fixes all of that with a small reorganisation of the codebase and addition of some config files. It also upgrades prettier.

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Feb 15, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 15, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c3604c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes here that look good - but the tests are borked?

.prettierignore Show resolved Hide resolved
packages/website/src/vendor/typescript-vfs.d.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/integration-tests/jest.config.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #6473 (1c3604c) into v6 (cd26357) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##               v6    #6473   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         362      362           
  Lines       12473    12474    +1     
  Branches     3688     3688           
=======================================
+ Hits        10867    10868    +1     
  Misses       1260     1260           
  Partials      346      346           
Flag Coverage Δ
unittest 87.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin/src/rules/no-redundant-type-constituents.ts 93.79% <ø> (ø)
...lugin/src/rules/padding-line-between-statements.ts 93.83% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts 100.00% <ø> (ø)
packages/type-utils/src/getContextualType.ts 0.00% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts 100.00% <0.00%> (ø)

editFunc(contents),
].join('\n'),
'utf8',
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 +1, was going to ask for something like this

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bradzacher bradzacher merged commit 98dec37 into v6 Feb 16, 2023
@bradzacher bradzacher deleted the v6-fix-lint branch February 16, 2023 21:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants