chore(typescript-estree): remove unnecessary this.inTypeMode field

[bradzacher]

PR Checklist

• Addresses an existing open issue: fixes Bump minimum supported TS version to 4.2 to match DefinitelyTyped's 2y version support window #5914
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

I missed this when I did #5915 - this piece of converter state is now completely unnecessary because #5915 cleaned up the last reference to it.

This PR just deletes the now unused code.

[typescript-eslint]

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1dba0d6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• Node 18 - nx test typescript-estree
• nx run-many --target=lint --all --parallel
• Node 14 - nx test typescript-estree --coverage=false
• Node 18 - nx test utils
• Node 18 - nx test type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx test scope-manager
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test parser
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test eslint-plugin-tslint
• Node 14 - nx test utils --coverage=false
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx test parser --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test visitor-keys --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test ast-spec
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #6375 (1dba0d6) into v6 (c8c0a14) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #6375      +/-   ##
==========================================
- Coverage   91.63%   91.62%   -0.01%     
==========================================
  Files         354      354              
  Lines       12202    12196       -6     
  Branches     3583     3582       -1     
==========================================
- Hits        11181    11175       -6     
  Misses        721      721              
  Partials      300      300              

Flag	Coverage Δ
unittest	91.62% <91.66%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	97.19% <91.66%> (-0.03%)	⬇️

[JoshuaKGoldberg]

yeet