fix(typescript-estree): account for namespace nesting in AST conversion

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes Bug: incorrect AST produced for nested namespaces #4966
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

TypeScript produces a nested body AST for Identifier names like abc.def. This unravels their body blocks and accumulates the name if necessary.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 052acab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 14 - nx test eslint-plugin --coverage=false
• Node 18 - nx test eslint-plugin
• Node 14 - nx test typescript-estree --coverage=false
• Node 18 - nx test typescript-estree
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test utils --coverage=false
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test parser --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=typecheck --parallel
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=lint --parallel
• Node 18 - nx test type-utils
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test scope-manager
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test ast-spec
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-internal
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-tslint
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test parser
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[codecov]

Codecov Report

Merging #6272 (052acab) into v6 (3915661) will decrease coverage by 0.12%.
The diff coverage is 11.11%.

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #6272      +/-   ##
==========================================
- Coverage   87.15%   87.04%   -0.12%     
==========================================
  Files         362      362              
  Lines       12459    12465       +6     
  Branches     3688     3689       +1     
==========================================
- Hits        10859    10850       -9     
- Misses       1253     1268      +15     
  Partials      347      347              

Flag	Coverage Δ
unittest	87.04% <11.11%> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-namespace.ts	100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts	28.21% <11.11%> (-0.49%)	⬇️
packages/eslint-plugin/src/rules/no-unused-vars.ts	91.81% <0.00%> (-4.10%)	⬇️

[bradzacher]

I do wish we could use Identifier for the dotted name - unfortunately Identifier.name needs to be a valid JS identifier - dots aren't allowed!

Instead we can convert this to a TSQualifiedName which is essentially just a special limtied member expression.

[bradzacher]

Now that #6443 has landed in main, we'll need to merge v6 then update this PR accordingly.

[bradzacher]