Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): deprecate no-type-alias #6229

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 16, 2022

PR Checklist

Overview

Adds deprecated: true to the rule's metadata and adds a couple of admonitions explaining it. Although the rule is indeed closer to no-restricted-syntax per #6036 (comment), I think it's easier for users to be explained that we recommend using consistent-type-definitions instead, + no-restricted-syntax if they really need.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Dec 16, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c794649. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Dec 16, 2022
@bradzacher bradzacher merged commit 820bdf2 into typescript-eslint:v6 Jan 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the deprecate-no-type-alias branch January 30, 2023 12:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants