Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [no-unsafe-enum-comparison] add rule #6107

Merged
merged 101 commits into from Apr 5, 2023
Merged

feat(eslint-plugin): [no-unsafe-enum-comparison] add rule #6107

merged 101 commits into from Apr 5, 2023

Commits on Apr 27, 2022

  1. feat: adding enums to member-ordering rule

    @Zamiell
    Zamiell committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    481fb44 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Merge branch 'main' into strict-enums

    @Zamiell
    Zamiell committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    5776a01 View commit details
    Browse the repository at this point in the history

  2. feat(eslint-plugin): [strict-enums] adding check for null/undefined

    @Zamiell
    Zamiell committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    094c90e View commit details
    Browse the repository at this point in the history

  3. feat(eslint-plugin): [strict-enums] refactoring tests to separate files

    @Zamiell
    Zamiell committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    311b1f8 View commit details
    Browse the repository at this point in the history

  4. feat(eslint-plugin): [strict-enums] allowing more operators

    @Zamiell
    Zamiell committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    ac5e6d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. fix(eslint-plugin): [strict-enums] adding union test

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7d55248 View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin): [strict-enums] refactoring + adding failing class 

    test
    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    74af3d1 View commit details
    Browse the repository at this point in the history

  3. fix(eslint-plugin): [strict-enums] adding constraint code

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    1eb70ee View commit details
    Browse the repository at this point in the history

  4. fix(eslint-plugin): [strict-enums] better eslint messages

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    cf006fd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into strict-enums

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    4d7f3fe View commit details
    Browse the repository at this point in the history

  6. fix(eslint-plugin): [strict-enums] removing vscode setting changes

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    2bbc2b7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into strict-enums

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    75c2252 View commit details
    Browse the repository at this point in the history

  8. fix: changing function definition to reflect reality

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    3976fdc View commit details
    Browse the repository at this point in the history

  9. fix: pass string enum literal into function that take string

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    2406d03 View commit details
    Browse the repository at this point in the history

  10. fix: allow passing enums to functions with any/unknown

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    4244376 View commit details
    Browse the repository at this point in the history

  11. fix: using flags instead of names 

    also fixes for codebase
    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    8b4dcdc View commit details
    Browse the repository at this point in the history

  12. fix: adding test that breaks the rule

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    12f8120 View commit details
    Browse the repository at this point in the history

  13. fix: adding test for variadic functions

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    e638718 View commit details
    Browse the repository at this point in the history

  14. fix: adding isSymbolFlagSet internally

    @Zamiell
    Zamiell committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    aef971a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. fix: adding ignoring for remaining lint failures

    @Zamiell
    Zamiell committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    75f60b9 View commit details
    Browse the repository at this point in the history

  2. fix: better comments

    @Zamiell
    Zamiell committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    d784aa0 View commit details
    Browse the repository at this point in the history

  3. fix: broken test

    @Zamiell
    Zamiell committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    811de98 View commit details
    Browse the repository at this point in the history

  4. fix: adding failing test for generic functions

    @Zamiell
    Zamiell committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    9a71d45 View commit details
    Browse the repository at this point in the history

  5. fix: refactoring tests + adding tests

    @Zamiell
    Zamiell committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    f93a02a View commit details
    Browse the repository at this point in the history

  6. fix: refactoring enum helper function locations

    @Zamiell
    Zamiell committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    2ced9f8 View commit details
    Browse the repository at this point in the history

  7. fix: cleanup

    @Zamiell
    Zamiell committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    0695c1b View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. fix: refactoring + fixing tests

    @Zamiell
    Zamiell committed May 1, 2022
    Configuration menu
    Copy the full SHA
    7272a95 View commit details
    Browse the repository at this point in the history

  2. fix: more tests

    @Zamiell
    Zamiell committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6ed1f66 View commit details
    Browse the repository at this point in the history

  3. fix: refactoring and making tests pass

    @Zamiell
    Zamiell committed May 1, 2022
    Configuration menu
    Copy the full SHA
    83c70e3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. fix: adding array code, all tests pass now

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    0ff3096 View commit details
    Browse the repository at this point in the history

  2. fix: adding failing test

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    ddebded View commit details
    Browse the repository at this point in the history

  3. fix: allow empty arrays

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c8b239b View commit details
    Browse the repository at this point in the history

  4. fix: adding logic for arrays with no enums

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    90981a9 View commit details
    Browse the repository at this point in the history

  5. fix: adding more tests

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    32dec63 View commit details
    Browse the repository at this point in the history

  6. fix: fixing test

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    d0dbcbb View commit details
    Browse the repository at this point in the history

  7. fix: fixing linter

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c63c518 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into strict-enums

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c5cf7f3 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into strict-enums

    @Zamiell
    Zamiell committed May 2, 2022
    Configuration menu
    Copy the full SHA
    1b26d74 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. fix: reverting comment fixes

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    6e4f705 View commit details
    Browse the repository at this point in the history

  2. fix: removing refactor

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a0a2ee6 View commit details
    Browse the repository at this point in the history

  3. fix: removing fixes to dot-notation

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    dbae5db View commit details
    Browse the repository at this point in the history

  4. fix: removing semi refactor

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    16965d9 View commit details
    Browse the repository at this point in the history

  5. fix: removing jest logic

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    8b8f8f8 View commit details
    Browse the repository at this point in the history

  6. fix: removing comparison operators check

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    5f437cc View commit details
    Browse the repository at this point in the history

  7. fix: adding failing test

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    b1dbeb6 View commit details
    Browse the repository at this point in the history

  8. fix: making test pass

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    25caa05 View commit details
    Browse the repository at this point in the history

  9. fix: adding comment

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    f42de61 View commit details
    Browse the repository at this point in the history

  10. fix: adding back in bitwise operator checks since apparently they are 

    needed
    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a866ddd View commit details
    Browse the repository at this point in the history

  11. fix: remove bad comment

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    61cf107 View commit details
    Browse the repository at this point in the history

  12. fix: removing unnecessary comments

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    304d796 View commit details
    Browse the repository at this point in the history

  13. fix: remove types from error messages

    @Zamiell
    Zamiell committed May 3, 2022
    Configuration menu
    Copy the full SHA
    83c5f30 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. fix: removing isArray + refactoring

    @Zamiell
    Zamiell committed May 4, 2022
    Configuration menu
    Copy the full SHA
    23ac918 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into strict-enums

    @Zamiell
    Zamiell committed May 4, 2022
    Configuration menu
    Copy the full SHA
    098d732 View commit details
    Browse the repository at this point in the history

  3. Update packages/eslint-plugin/src/rules/strict-enums.ts 

    Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
    @Zamiell @bradzacher
    Zamiell and bradzacher committed May 4, 2022
    Configuration menu
    Copy the full SHA
    99424e1 View commit details
    Browse the repository at this point in the history

  4. fix: removing strict-enums from recommended

    @Zamiell
    Zamiell committed May 4, 2022
    Configuration menu
    Copy the full SHA
    0de3b26 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. fix: simplify

    @Zamiell
    Zamiell committed May 5, 2022
    Configuration menu
    Copy the full SHA
    2d488cc View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. fix: undoing refactoring

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    15dc3df View commit details
    Browse the repository at this point in the history

  2. fix: undoing refactoring

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a3d0122 View commit details
    Browse the repository at this point in the history

  3. fix: moving tests into subdirectory

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    5cd8fa7 View commit details
    Browse the repository at this point in the history

  4. Update packages/eslint-plugin/src/rules/strict-enums.ts 

    Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
    @Zamiell @bradzacher
    Zamiell and bradzacher committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a236085 View commit details
    Browse the repository at this point in the history

  5. Update packages/eslint-plugin/src/rules/strict-enums.ts 

    Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
    @Zamiell @bradzacher
    Zamiell and bradzacher committed May 6, 2022
    Configuration menu
    Copy the full SHA
    c357432 View commit details
    Browse the repository at this point in the history

  6. fix: adding failing test

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    2395998 View commit details
    Browse the repository at this point in the history

  7. fix: making boolean tests pass

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    2851c3b View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into strict-enums

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    149c049 View commit details
    Browse the repository at this point in the history

  9. fix: refactor tests + fix linter

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    cf7c9b7 View commit details
    Browse the repository at this point in the history

  10. fix: adding brads tests

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    3b2fa57 View commit details
    Browse the repository at this point in the history

  11. fix: brads tests now pass

    @Zamiell
    Zamiell committed May 6, 2022
    Configuration menu
    Copy the full SHA
    6c43f71 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2022

  1. Update packages/eslint-plugin/docs/rules/strict-enums.md 

    Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
    @Zamiell @Josh-Cena
    Zamiell and Josh-Cena committed May 7, 2022
    Configuration menu
    Copy the full SHA
    af7d5da View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Merge branch 'main' into strict-enums

    @Zamiell
    Zamiell committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a50f6e1 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Update packages/eslint-plugin/src/rules/strict-enums.ts 

    Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
    @Zamiell @bradzacher
    Zamiell and bradzacher committed May 30, 2022
    Configuration menu
    Copy the full SHA
    85563be View commit details
    Browse the repository at this point in the history

  2. Update packages/eslint-plugin/src/rules/strict-enums.ts 

    Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
    @Zamiell @bradzacher
    Zamiell and bradzacher committed May 30, 2022
    Configuration menu
    Copy the full SHA
    ee96ce5 View commit details
    Browse the repository at this point in the history

  3. Update packages/eslint-plugin/src/rules/strict-enums.ts 

    Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
    @Zamiell @bradzacher
    Zamiell and bradzacher committed May 30, 2022
    Configuration menu
    Copy the full SHA
    943bf9f View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. fix: make brads updates actually compile

    @Zamiell
    Zamiell committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    7679c4a View commit details
    Browse the repository at this point in the history

  2. Update strict-enums.ts

    @Zamiell
    Zamiell committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    871e9ca View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Merge branch 'main'

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    f861606 View commit details
    Browse the repository at this point in the history

  2. Continued fixing merge conflicts

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    cbe9e90 View commit details
    Browse the repository at this point in the history

  3. Continued fixing the build

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    c37165c View commit details
    Browse the repository at this point in the history

  4. Passing build

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    3f37c67 View commit details
    Browse the repository at this point in the history

  5. Update packages/eslint-plugin/src/rules/strict-enums.ts

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    c942261 View commit details
    Browse the repository at this point in the history

  6. Update packages/eslint-plugin/src/rules/strict-enums.ts

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    b2947f9 View commit details
    Browse the repository at this point in the history

  7. A few more reverts

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    a7772d2 View commit details
    Browse the repository at this point in the history

  8. Just a bit more changing typeFlagUtils

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    4204a60 View commit details
    Browse the repository at this point in the history

  9. Fixed strict-enums.md build

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    89bcd73 View commit details
    Browse the repository at this point in the history

  10. Convert tests to not pushing

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    4f13db4 View commit details
    Browse the repository at this point in the history

  11. Simplified the rule a whole bunch

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    4706e4f View commit details
    Browse the repository at this point in the history

  12. Add back getEnumNames

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    be144e3 View commit details
    Browse the repository at this point in the history

  13. Even more trimming down

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    e4ac325 View commit details
    Browse the repository at this point in the history

  14. ...and just a bit more

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    62ccdb1 View commit details
    Browse the repository at this point in the history

  15. Undo some JSDoc changes

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    da7501a View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. Progress: no-unsafe-enum-assignment is tested

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    83c33cb View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. A bit more testing for assignments, as requested

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    a3e6236 View commit details
    Browse the repository at this point in the history

  2. Finished testing and sharing

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    f1071fa View commit details
    Browse the repository at this point in the history

  3. Added comparison operators

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    680293a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main'

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    51bc2b1 View commit details
    Browse the repository at this point in the history

  5. Added back no-unsafe-enum-comparison

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    14cceea View commit details
    Browse the repository at this point in the history

  6. Remove unrelated changes

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    bc65e3c View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. Merge branch 'main' into no-unsafe-enum-comparison

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    adf6f2e View commit details
    Browse the repository at this point in the history

  2. Reduce coverage

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    68ad65c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge branch 'main'

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    57376a7 View commit details
    Browse the repository at this point in the history

  2. Touched up docs

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    559c0ab View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into no-unsafe-enum-comparison

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b1c9bec View commit details
    Browse the repository at this point in the history