Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: raise tsconfig target to ES2021 #5981

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Nov 13, 2022

BREAKING CHANGE:
Updates the internal TSConfig target to ES2021.

Fixes #5980.

I didn't see any other production files to update this in. All the other tsconfig.json files present are test fixtures. Let me know if we should update those too.

Potential breaking change targeting v6 (#5886).

@nx-cloud
Copy link

nx-cloud bot commented Nov 13, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bda4d55. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bmish!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad this was all that was needed. Thanks for sending this in!

@JoshuaKGoldberg JoshuaKGoldberg merged commit d4b0259 into typescript-eslint:v6 Nov 13, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: raise tsconfig target to ES2021 chore: raise tsconfig target to ES2021 Nov 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants