Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for ESLint v6 #5972

Merged
merged 1 commit into from Nov 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-plugin-tslint/package.json
Expand Up @@ -42,7 +42,7 @@
"lodash": "^4.17.21"
},
"peerDependencies": {
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0",
"eslint": "^7.0.0 || ^8.0.0",
"tslint": "^5.0.0 || ^6.0.0",
"typescript": "*"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/package.json
Expand Up @@ -69,7 +69,7 @@
},
"peerDependencies": {
"@typescript-eslint/parser": "^5.0.0",
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
"eslint": "^7.0.0 || ^8.0.0"
},
"peerDependenciesMeta": {
"typescript": {
Expand Down
2 changes: 1 addition & 1 deletion packages/experimental-utils/package.json
Expand Up @@ -41,7 +41,7 @@
"@typescript-eslint/utils": "5.41.0"
},
"peerDependencies": {
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
"eslint": "^7.0.0 || ^8.0.0"
},
"devDependencies": {
"typescript": "*"
Expand Down
2 changes: 1 addition & 1 deletion packages/parser/package.json
Expand Up @@ -42,7 +42,7 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"peerDependencies": {
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
"eslint": "^7.0.0 || ^8.0.0"
},
"dependencies": {
"@typescript-eslint/scope-manager": "5.41.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/type-utils/package.json
Expand Up @@ -49,7 +49,7 @@
"typescript": "*"
},
"peerDependencies": {
"eslint": "*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we might as well include the constraint here too.

"eslint": "^7.0.0 || ^8.0.0"
},
"peerDependenciesMeta": {
"typescript": {
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/package.json
Expand Up @@ -48,7 +48,7 @@
"semver": "^7.3.7"
},
"peerDependencies": {
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
"eslint": "^7.0.0 || ^8.0.0"
},
"devDependencies": {
"@typescript-eslint/parser": "5.41.0",
Expand Down
@@ -1,5 +1,5 @@
{
"devDependencies": {
"eslint": "6.0.0"
"eslint": "7.0.0"
}
}
28 changes: 0 additions & 28 deletions tests/integration/tests/__snapshots__/eslint-v6.test.ts.snap

This file was deleted.

53 changes: 53 additions & 0 deletions tests/integration/tests/__snapshots__/eslint-v7.test.ts.snap
@@ -0,0 +1,53 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`eslint-v7 should lint successfully 1`] = `
[
{
"errorCount": 1,
"filePath": "<root>/index.ts",
"fixableErrorCount": 0,
"fixableWarningCount": 0,
"messages": [
{
"column": 15,
"endColumn": 18,
"endLine": 1,
"line": 1,
"message": "Unexpected any. Specify a different type.",
"messageId": "unexpectedAny",
"nodeType": "TSAnyKeyword",
"ruleId": "@typescript-eslint/no-explicit-any",
"severity": 2,
"suggestions": [
{
"desc": "Use \`unknown\` instead, this will force you to explicitly, and safely assert the type is correct.",
"fix": {
"range": [
14,
17,
],
"text": "unknown",
},
"messageId": "suggestUnknown",
},
{
"desc": "Use \`never\` instead, this is useful when instantiating generic type parameters that you don't need to know the type of.",
"fix": {
"range": [
14,
17,
],
"text": "never",
},
"messageId": "suggestNever",
},
],
},
],
"source": "const noSemi: any = true;
",
"usedDeprecatedRules": [],
"warningCount": 0,
},
]
`;