Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): wrap import = declaration in an export node #5885

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 25, 2022

BREAKING CHANGE:
Removes AST property and changes AST structure

PR Checklist

Overview

A note from our pairing: it's fine to create as many (multiple) nodes as we like from one original node.

Co-authored-by: Brad Zacher brad.zacher@gmail.com

@nx-cloud
Copy link

nx-cloud bot commented Oct 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 79a5f81. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7a25528
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63586cb819d7ed0008f64301
😎 Deploy Preview https://deploy-preview-5885--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Andarist and others added 2 commits October 25, 2022 19:59
…pescript-eslint#5036)

* refactor(utils)!: removed `TRuleListener` generic from the `createRule`

* refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction`

* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)

* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)

* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)

* docs: Mention wide globs performance implications in monorepos docs and parser readme

* Update docs/linting/typed-linting/MONOREPOS.md

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…ipt-eslint#3076)

* feat: update TSImportType node

* fix: update visitor keys

* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)

* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)

* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)

* docs: Mention wide globs performance implications in monorepos docs and parser readme

* Update docs/linting/typed-linting/MONOREPOS.md

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Oct 26, 2022
@bradzacher bradzacher changed the base branch from main to v6 October 26, 2022 01:41
@bradzacher bradzacher added this to the 6.0.0 milestone Oct 26, 2022
JoshuaKGoldberg and others added 8 commits October 25, 2022 23:12
* feat(scope-manager): ignore ECMA version

* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)

* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)

* Remove much more

* Fix WebLinter lint

* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)

* docs: Mention wide globs performance implications in monorepos docs and parser readme

* Update docs/linting/typed-linting/MONOREPOS.md

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

* chore: add auto-canary release for v6 (typescript-eslint#5883)

Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…TSInterfaceDeclaration and TSModuleDeclaration (typescript-eslint#4863)

* chore: remove invalid properties from ast nodes

* chore: remove invalid code in scope-manager and typescript-estree

* chore: re-write snapshots that were using invalid properties

* feat: remove modifiers union from ast types

Co-authored-by: Juan García <juank1809@gmail.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
* chore(utils)\!: remove (ts-)eslint-scope types

* Remove eslint-scope dep

* More file deletions
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #5885 (79a5f81) into v6 (9c17395) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v6    #5885   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         359      359           
  Lines       12400    12400           
  Branches     3653     3653           
=======================================
  Hits        11393    11393           
  Misses        703      703           
  Partials      304      304           
Flag Coverage Δ
unittest 91.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 97.19% <100.00%> (ø)

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 16, 2022 20:09
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

futureisnow_oldman

@bradzacher
Copy link
Member

I think this needs a rebase before merging?

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1c3f470 into typescript-eslint:v6 Feb 4, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the import-equals-wrap-node branch February 4, 2023 17:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released
Projects
None yet
5 participants