feat(eslint-plugin): rework configs: recommended, strict, stylistic; -type-checked #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
added
the
breaking change
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
commented
Jun 26, 2022
bradzacher
changed the title
…pescript-eslint#5036) * refactor(utils)!: removed `TRuleListener` generic from the `createRule` * refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction` * chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834) * chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882) * docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…ipt-eslint#3076) * feat: update TSImportType node * fix: update visitor keys * chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834) * chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882) * docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
* feat(scope-manager): ignore ECMA version * chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834) * chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882) * Remove much more * Fix WebLinter lint * docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> * chore: add auto-canary release for v6 (typescript-eslint#5883) Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…TSInterfaceDeclaration and TSModuleDeclaration (typescript-eslint#4863) * chore: remove invalid properties from ast nodes * chore: remove invalid code in scope-manager and typescript-estree * chore: re-write snapshots that were using invalid properties * feat: remove modifiers union from ast types Co-authored-by: Juan García <juank1809@gmail.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
* chore(utils)\!: remove (ts-)eslint-scope types * Remove eslint-scope dep * More file deletions
…ckReferences option from schema (typescript-eslint#5399)
JoshuaKGoldberg
commented
Dec 18, 2022
bradzacher
requested changes
Feb 1, 2023
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
bradzacher
approved these changes
Feb 13, 2023
packages/eslint-plugin/src/index.ts
Outdated
Comment on lines
19
to
20
| 'recommended-requiring-type-checking': recommendedRequiringTypeChecking, | ||
| 'recommended-type-checked': recommendedTypeChecked, |
There was a problem hiding this comment.
i was going to say you could save that one file and do this instead:
Suggested change
| 'recommended-requiring-type-checking': recommendedRequiringTypeChecking, | |
| 'recommended-type-checked': recommendedTypeChecked, | |
| 'recommended-requiring-type-checking': recommendedTypeChecked, | |
| 'recommended-type-checked': recommendedTypeChecked, |
There was a problem hiding this comment.
Oh ha yeah true. And on top of this & v6 overall already being breaking changes, with #6458 we don't have to worry about people reaching into dist/. Great.
bradzacher
added
the
1 approval
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
changes the recommended configs
PR Checklist
Overview
Has each config after
recommendedalso include all rules from prior configs. Simplifies what users will have to configure by letting them only specify the strictest desired config.This is being used to generate the table in #6014.