Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: Add a CI check that 'breaking change' PR descriptions start with the right title text #9027

Open
JoshuaKGoldberg opened this issue Apr 29, 2024 · 0 comments · May be fixed by #9050
Open

Repo: Add a CI check that 'breaking change' PR descriptions start with the right title text #9027

JoshuaKGoldberg opened this issue Apr 29, 2024 · 0 comments · May be fixed by #9050
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Our breaking change PRs don't need ! in their title. In fact, we're not even sure our semantic release notes generator supports ! at all! Let's add a CI check to ensure that no PR titles include !.

Example where I forgot about this: #8934

Related to #5884. That one is about the PR body. This one is about the PR title.
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Apr 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 29, 2024
Merged
3 tasks
@yeonjuan yeonjuan linked a pull request May 6, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add breaking change pr check ci yeonjuan/typescript-eslint
1 participant
@JoshuaKGoldberg