New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yarn version not specified in monorepo #7371
Conversation
…v6.md Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
…v6.md Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Thanks for the PR, @Zamiell! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -144,5 +144,6 @@ | |||
"pretty-format": "^29", | |||
"tsx": "^3.12.7", | |||
"typescript": "5.1.6" | |||
} | |||
}, | |||
"packageManager": "yarn@1.22.19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesHenry fyi as #6162 is upcoming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that shouldn't really affect this pr
@@ -63,7 +63,7 @@ As a result, we've reworked the configurations provided by typescript-eslint int | |||
|
|||
- Functional rule configurations, for best best practices and code correctness: | |||
- **`recommended`**: Recommended rules that you can drop in without additional configuration. | |||
- **`recommended-type-checked`**: Additional recommended rules that require type information. | |||
- **`recommended-type-checked`**: Additional recommended rules that require type information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the deal with this diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea, it showed up as different when I copy pasted the md file from the main branch. are they different kind of spaces or something? I tried copy pasting them into this site and they both show up as normal spaces, so I'm not really sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git checkout main -- packages/website/blog/2023-07-09-announcing-typescript-eslint-v6.md
fixed it for me. 🤷
Now that #6162 is finally up to date and green, we can potentially skip this PR as the same field is added in that PR for yarn v3 |
Looks like #6162 is pretty close! I'll merge this in the meantime to give Zamiell contribution credit in the Git history / on github dot com. 😄 |
18f8d74
into
typescript-eslint:main
Blurgh, I didn't think to change the PR title to |
PR Checklist
Overview
Adds explicit yarn version to prevent broken installs for new people cloning the repository.