Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn version not specified in monorepo #7371

Merged
merged 12 commits into from Jul 31, 2023

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Jul 28, 2023

PR Checklist

Overview

Adds explicit yarn version to prevent broken installs for new people cloning the repository.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b678ef2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64c71fd1d276e80008edaa1b
😎 Deploy Preview https://deploy-preview-7371--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zamiell Zamiell changed the title Yarn fix: yarn version not specified in monorepo Jul 28, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b678ef2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@@ -144,5 +144,6 @@
"pretty-format": "^29",
"tsx": "^3.12.7",
"typescript": "5.1.6"
}
},
"packageManager": "yarn@1.22.19"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesHenry fyi as #6162 is upcoming

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that shouldn't really affect this pr

@@ -63,7 +63,7 @@ As a result, we've reworked the configurations provided by typescript-eslint int

- Functional rule configurations, for best best practices and code correctness:
- **`recommended`**: Recommended rules that you can drop in without additional configuration.
- **`recommended-type-checked`**: Additional recommended rules that require type information.
- **`recommended-type-checked`**: Additional recommended rules that require type information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the deal with this diff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, it showed up as different when I copy pasted the md file from the main branch. are they different kind of spaces or something? I tried copy pasting them into this site and they both show up as normal spaces, so I'm not really sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git checkout main -- packages/website/blog/2023-07-09-announcing-typescript-eslint-v6.md fixed it for me. 🤷

@JamesHenry
Copy link
Member

Now that #6162 is finally up to date and green, we can potentially skip this PR as the same field is added in that PR for yarn v3

@JoshuaKGoldberg
Copy link
Member

Looks like #6162 is pretty close! I'll merge this in the meantime to give Zamiell contribution credit in the Git history / on github dot com. 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit 18f8d74 into typescript-eslint:main Jul 31, 2023
49 of 51 checks passed
@JoshuaKGoldberg
Copy link
Member

Blurgh, I didn't think to change the PR title to chore:, and now it's in the release log. Ah well 🙃

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
@Zamiell Zamiell deleted the yarn branch September 17, 2023 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: should specify yarn version
3 participants