fix(scope-manager): correct decorators(.length) check in ClassVisitor for methods

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes Bug: [consistent-type-imports] "used by decorator metadata" false positive for type used in constructor parameter #7327
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Adds a missing .decorators check and updates snapshots.

I tried for a bit to get a @typescript-eslint/consistent-type-imports unit test to fail without the change, but couldn't.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	2b8ed41
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64c450eebe80ec0008dd668d
😎 Deploy Preview	https://deploy-preview-7334--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b8ed41. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 35 targets

• nx test eslint-plugin --coverage=false
• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• Node 20 - nx test visitor-keys
• Node 20 - nx run types:build
• Node 20 - nx test scope-manager
• Node 20 - nx test utils
• Node 20 - nx test type-utils
• Node 20 - nx test typescript-estree
• Node 20 - nx test repo-tools
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test parser
• Node 20 - nx test eslint-plugin-tslint
• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx run types:build
• nx run-many --target=typecheck --parallel
• Node 20 - nx test ast-spec
• Node 16 - nx test utils --coverage=false
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test typescript-estree --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• nx run-many --target=lint --parallel
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• nx test typescript-estree --coverage=false
• nx run types:build
• nx test eslint-plugin-internal --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx run integration-tests:test
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[bradzacher]

can you also add the issue snippet as a test case to the consistent-type-imports rule?

[JoshuaKGoldberg]

I can't get it to fail on main 😕 Aha! I was missing parserOptions: { emitDecoratorMetadata: true }. Thanks for the prod - will add.