Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: Raise tsconfig target #5980

Closed
bmish opened this issue Nov 13, 2022 · 1 comment
Closed

Repo: Raise tsconfig target #5980

bmish opened this issue Nov 13, 2022 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released good first issue Good for newcomers repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@bmish
Copy link
Contributor

bmish commented Nov 13, 2022

Suggestion

Consider whether we should raise tsconfig target / lib from ES2017 to something higher.

typescript-eslint/tsconfig.base.json

Lines 16 to 17 in 91d71bc

"target": "es2017",
"lib": ["es2017"],

We're already planning to increase requirements for v6 including:

This all seems to indicate people would have a relatively modern environment to run TypeScript linting in.

The newest possible we could use is ES2021, is that too new or is there any reason we couldn't use that?

This may be a breaking change that could be included with v6 (#5886).
@bmish bmish added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for maintainers to take a look labels Nov 13, 2022
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Nov 13, 2022 •
edited

Seems reasonable to me! Agreed on including it in v6 just to be safe.

Marking as accepting PRs that someone could search through all of our TSConfig files -tsconfig.json, tsconfig.base.json, any others- and switch "es2017" to "es2021".

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers breaking change This change will require a new major version to be released accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Nov 13, 2022
@bmish bmish mentioned this issue Nov 13, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released good first issue Good for newcomers repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmish @JoshuaKGoldberg