Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for NodeJS v12 #5917

Closed
bradzacher opened this issue Nov 2, 2022 · 3 comments
Closed

Drop support for NodeJS v12 #5917

bradzacher opened this issue Nov 2, 2022 · 3 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package
Milestone
6.0.0

Comments

@bradzacher
Copy link
Member

Suggestion

https://github.com/nodejs/Release/blob/main/schedule.json#L66

NodeJS v12 was EOL 2022-04-30.
We also stopped testing on Node v12 in #5512 last month - so we don't even have signal if we have support!
@bradzacher bradzacher added breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package labels Nov 2, 2022
@bradzacher bradzacher added this to the 6.0.0 milestone Nov 2, 2022
@bradzacher bradzacher added the accepting prs Go ahead, send a pull request that resolves this issue label Nov 2, 2022
@bradzacher bradzacher mentioned this issue Nov 2, 2022
Merged
3 tasks
@bradzacher
Copy link
Member Author

As per #5886 (comment) by @bmish

Let's make the dependency range "^14.18.0 || ^16.0.0 || >=18.0.0"

  • 14.18 means we can switch our node lib imports to 'node:fs'
  • v17 is EOL, so no reason we should include it in our ranges still.

@bradzacher bradzacher mentioned this issue Nov 11, 2022
Merged
@bmish bmish mentioned this issue Nov 11, 2022
Merged
@bmish
Copy link
Contributor

bmish commented Nov 11, 2022 •
edited

This issue should be closed. Not sure why GitHub didn't automatically close it when PR was merged.

@JoshuaKGoldberg
Copy link
Member

Oh yeah, it's been not closing them when they're merged into v6. 🤷

@bmish bmish mentioned this issue Nov 13, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
3 participants
@bmish @JoshuaKGoldberg @bradzacher