fix(typescript-estree): fix error handling on ImportExpression (#6587)

packages/ast-spec/src/expression/ImportExpression/fixtures/_error_/extra-arguments/fixture.ts

@@ -0,0 +1,5 @@
+import(
+  "./source.json",
+  {assert: {type: "json"}},
+  extraArgument
+);

packages/ast-spec/src/expression/ImportExpression/fixtures/_error_/extra-arguments/snapshots/1-TSESTree-Error.shot

@@ -0,0 +1,11 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`AST Fixtures expression ImportExpression _error_ extra-arguments TSESTree - Error 1`] = `
+"TSError
+  2 |   \\"./source.json\\",
+  3 |   {assert: {type: \\"json\\"}},
+> 4 |   extraArgument
+    |   ^^^^^^^^^^^^^ Dynamic import requires exactly one or two arguments.
+  5 | );
+  6 |"
+`;

packages/ast-spec/src/expression/ImportExpression/fixtures/_error_/extra-arguments/snapshots/2-Babel-Error.shot

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`AST Fixtures expression ImportExpression _error_ extra-arguments Babel - Error 1`] = `[SyntaxError: \`import()\` requires exactly one or two arguments. (1:0)]`;

packages/ast-spec/src/expression/ImportExpression/fixtures/_error_/extra-arguments/snapshots/3-Alignment-Error.shot

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`AST Fixtures expression ImportExpression _error_ extra-arguments Error Alignment 1`] = `"Both errored"`;

packages/ast-spec/src/expression/ImportExpression/fixtures/_error_/no-arguments/fixture.ts

@@ -0,0 +1 @@
+import();

packages/ast-spec/src/expression/ImportExpression/fixtures/_error_/no-arguments/snapshots/1-TSESTree-Error.shot

@@ -0,0 +1,8 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`AST Fixtures expression ImportExpression _error_ no-arguments TSESTree - Error 1`] = `
+"TSError
+> 1 | import();
+    | ^^^^^^^^ Dynamic import requires exactly one or two arguments.
+  2 |"
+`;

packages/ast-spec/src/expression/ImportExpression/fixtures/_error_/no-arguments/snapshots/2-Babel-Error.shot

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`AST Fixtures expression ImportExpression _error_ no-arguments Babel - Error 1`] = `[SyntaxError: \`import()\` requires exactly one or two arguments. (1:0)]`;

packages/ast-spec/src/expression/ImportExpression/fixtures/_error_/no-arguments/snapshots/3-Alignment-Error.shot

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`AST Fixtures expression ImportExpression _error_ no-arguments Error Alignment 1`] = `"Both errored"`;

packages/typescript-estree/src/convert.ts

@@ -2059,7 +2059,7 @@ export class Converter {
         if (node.expression.kind === SyntaxKind.ImportKeyword) {
           if (node.arguments.length !== 1 && node.arguments.length !== 2) {
             this.#throwUnlessAllowInvalidAST(
-              node.arguments[0],
+              node.arguments[2] ?? node,
               'Dynamic import requires exactly one or two arguments.',
             );
           }