feat: bump ESLint, NodeJS, and TS minimum version requirements

BREAKING CHANGE: Bumps the minimum requirements
typescript-eslint · Feb 4, 2024 · e5db5a3 · e5db5a3
1 parent aa5edf7
commit e5db5a3
Show file tree

Hide file tree

Showing 38 changed files with 77 additions and 364 deletions.
diff --git a/.github/actions/wait-for-netlify/action.yml b/.github/actions/wait-for-netlify/action.yml
@@ -11,5 +11,5 @@ inputs:
     description: How long to wait between retries of the Netlify api
 
 runs:
-  using: node16
+  using: node20
   main: index.js
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -156,10 +156,10 @@ jobs:
       matrix:
         exclude:
           - os: windows-latest
-            node-version: 16
+            node-version: 18
         os: [ubuntu-latest, windows-latest]
         # just run on the oldest and latest supported versions and assume the intermediate versions are good
-        node-version: [16, 20]
+        node-version: [18, 20]
         package:
           [
             'ast-spec',

diff --git a/docs/maintenance/pull-requests/Dependency_Version_Upgrades.mdx b/docs/maintenance/pull-requests/Dependency_Version_Upgrades.mdx
@@ -116,6 +116,7 @@ A single PR can remove support for old TypeScript versions as a breaking change:
 1. Update the `SUPPORTED_TYPESCRIPT_VERSIONS` constant in `warnAboutTSVersion.ts`
 1. Update the `versions` constant in `version-check.ts`
 1. Update [Users > Dependency Versions > TypeScript](../../users/Dependency_Versions.mdx#typescript)
+1. Update `MIN_TS_VERSION_SEMVER` in `packages/website/src/components/OptionsSelector.tsx`
 1. Search for source code comments (excluding `CHANGELOG.md` files) that mention a now-unsupported version of TypeScript.
    - For example, to remove support for v4.3, searches might include:
      - `4.3`

diff --git a/docs/users/Dependency_Versions.mdx b/docs/users/Dependency_Versions.mdx
@@ -7,13 +7,25 @@ import packageJson from '../../package.json';
 
 ## ESLint
 
-> The version range of ESLint currently supported is `^7.0.0 || ^8.0.0`.
+<blockquote>
+  <p>
+    The version range of ESLint currently supported is{' '}
+    <code>{packageJson.devDependencies.eslint}</code>.
+  </p>
+</blockquote>
 
-We generally support at least the latest two major versions of ESLint.
+We generally support at least the latest two major versions of ESLint; though sometimes we may restrict this if the APIs change too much between major releases.
 
 ## Node
 
-This project makes an effort to support Active LTS and Maintenance LTS release statuses of Node according to [Node's release document](https://github.com/nodejs/release#release-schedule).
+<blockquote>
+  <p>
+    The version range of NodeJS currently supported is{' '}
+    <code>{packageJson.engines.node}</code>.
+  </p>
+</blockquote>
+
+We make an effort to support Active LTS and Maintenance LTS release statuses of Node according to [Node's release document](https://github.com/nodejs/release#release-schedule).
 Support for specific Current status releases are considered periodically.
 
 ## TypeScript
@@ -25,7 +37,7 @@ Support for specific Current status releases are considered periodically.
   </p>
 </blockquote>
 
-Note that we mirror [DefinitelyTyped's version support window](https://github.com/DefinitelyTyped/DefinitelyTyped/#support-window) - meaning we only support versions of TypeScript less than 2 years old.
+We mirror [DefinitelyTyped's version support window](https://github.com/DefinitelyTyped/DefinitelyTyped/#support-window) - meaning we only support versions of TypeScript less than 2 years old.
 
 You may find that our tooling works on older TypeScript versions however we provide no guarantees and **_we will not accept issues against unsupported versions_**.
 

diff --git a/package.json b/package.json
@@ -50,7 +50,7 @@
     "typecheck": "npx nx run-many --target=typecheck --parallel"
   },
   "engines": {
-    "node": "^16.0.0 || >=18.0.0"
+    "node": "^18.18.0 || >=20.0.0"
   },
   "devDependencies": {
     "@actions/core": "^1.10.0",
@@ -84,7 +84,7 @@
     "cross-fetch": "^4.0.0",
     "cspell": "^7.0.0",
     "downlevel-dts": ">=0.11.0",
-    "eslint": "^8.56.0",
+    "eslint": "8.56.0",
     "eslint-plugin-deprecation": "^2.0.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-eslint-plugin": "^5.2.1",
@@ -117,7 +117,7 @@
     "ts-node": "10.7.0",
     "tslint": "^6.1.3",
     "tsx": "^4.6.2",
-    "typescript": ">=4.3.5 <5.4.0",
+    "typescript": ">=4.7.4 <5.4.0",
     "typescript-eslint": "workspace:^",
     "yargs": "17.7.2"
   },
@@ -139,6 +139,7 @@
     "@types/estree": "link:./tools/dummypkg",
     "@types/node": "^20.0.0",
     "@types/react": "^18.2.14",
+    "eslint": "8.56.0",
     "eslint-visitor-keys": "^3.4.1",
     "jest-config": "^29",
     "jest-resolve": "^29",

diff --git a/packages/eslint-plugin/src/rules/block-spacing.ts b/packages/eslint-plugin/src/rules/block-spacing.ts
@@ -66,7 +66,7 @@ export default createRule<Options, MessageIds>({
     function isValid(left: TSESTree.Token, right: TSESTree.Token): boolean {
       return (
         !isTokenOnSameLine(left, right) ||
-        sourceCode.isSpaceBetween!(left, right) === always
+        sourceCode.isSpaceBetween(left, right) === always
       );
     }
 

diff --git a/packages/eslint-plugin/src/rules/object-curly-spacing.ts b/packages/eslint-plugin/src/rules/object-curly-spacing.ts
@@ -173,7 +173,7 @@ export default createRule<Options, MessageIds>({
       last: TSESTree.Token,
     ): void {
       if (isTokenOnSameLine(first, second)) {
-        const firstSpaced = sourceCode.isSpaceBetween!(first, second);
+        const firstSpaced = sourceCode.isSpaceBetween(first, second);
         const secondType = sourceCode.getNodeByRangeIndex(
           second.range[0],
         )!.type;
@@ -221,7 +221,7 @@ export default createRule<Options, MessageIds>({
             ? !options.spaced
             : options.spaced;
 
-        const lastSpaced = sourceCode.isSpaceBetween!(penultimate, last);
+        const lastSpaced = sourceCode.isSpaceBetween(penultimate, last);
 
         if (closingCurlyBraceMustBeSpaced && !lastSpaced) {
           reportRequiredEndingSpace(node, last);

diff --git a/packages/eslint-plugin/src/rules/promise-function-async.ts b/packages/eslint-plugin/src/rules/promise-function-async.ts
@@ -183,7 +183,7 @@ export default createRule<Options, MessageIds>({
             }
 
             // check if there is a space between key and previous token
-            const insertSpace = !sourceCode.isSpaceBetween!(
+            const insertSpace = !sourceCode.isSpaceBetween(
               sourceCode.getTokenBefore(keyToken)!,
               keyToken,
             );

diff --git a/packages/eslint-plugin/src/rules/space-infix-ops.ts b/packages/eslint-plugin/src/rules/space-infix-ops.ts
@@ -94,8 +94,8 @@ export default createRule<Options, MessageIds>({
       const next = sourceCode.getTokenAfter(operator)!;
 
       if (
-        !sourceCode.isSpaceBetween!(prev, operator) ||
-        !sourceCode.isSpaceBetween!(operator, next)
+        !sourceCode.isSpaceBetween(prev, operator) ||
+        !sourceCode.isSpaceBetween(operator, next)
       ) {
         report(operator);
       }
@@ -148,8 +148,8 @@ export default createRule<Options, MessageIds>({
           const next = sourceCode.getTokenAfter(operator);
 
           if (
-            !sourceCode.isSpaceBetween!(prev!, operator) ||
-            !sourceCode.isSpaceBetween!(operator, next!)
+            !sourceCode.isSpaceBetween(prev!, operator) ||
+            !sourceCode.isSpaceBetween(operator, next!)
           ) {
             report(operator);
           }

diff --git a/packages/eslint-plugin/tests/rules/consistent-type-exports.test.ts b/packages/eslint-plugin/tests/rules/consistent-type-exports.test.ts
@@ -256,9 +256,6 @@ export { type T, T };
 type T = 1;
 export type { T, T };
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       errors: [
         {
           messageId: 'typeOverValue',
@@ -276,9 +273,6 @@ export { type/* */T, type     /* */T, T };
 type T = 1;
 export type { /* */T, /* */T, T };
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       errors: [
         {
           messageId: 'typeOverValue',
@@ -299,9 +293,6 @@ const x = 1;
 export type { T, T };
 export { x };
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       errors: [
         {
           messageId: 'singleExportIsType',
@@ -321,9 +312,6 @@ type T = 1;
 const x = 1;
 export { type T, x };
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       options: [{ fixMixedExportsWithInlineTypeSpecifier: true }],
       errors: [
         {
@@ -342,9 +330,6 @@ export { type T, T };
 type T = 1;
 export type { T, T };
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       options: [{ fixMixedExportsWithInlineTypeSpecifier: true }],
       errors: [
         {
@@ -367,9 +352,6 @@ export {
 export type { Type1, Type2 as Foo, value1 as BScope } from './consistent-type-exports';
 export { value2 as CScope } from './consistent-type-exports';
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       options: [{ fixMixedExportsWithInlineTypeSpecifier: false }],
       errors: [
         {
@@ -396,9 +378,6 @@ export {
   value2 as CScope,
 } from './consistent-type-exports';
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       options: [{ fixMixedExportsWithInlineTypeSpecifier: true }],
       errors: [
         {

diff --git a/packages/eslint-plugin/tests/rules/consistent-type-imports.test.ts b/packages/eslint-plugin/tests/rules/consistent-type-imports.test.ts
@@ -131,9 +131,6 @@ ruleTester.run('consistent-type-imports', rule, {
         const a: typeof Type = Type;
       `,
       options: [{ prefer: 'no-type-imports' }],
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
     },
     `
       import { type A } from 'foo';
@@ -208,9 +205,6 @@ ruleTester.run('consistent-type-imports', rule, {
         const b = B;
       `,
       options: [{ prefer: 'no-type-imports', fixStyle: 'inline-type-imports' }],
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
     },
     // exports
     `
@@ -1939,9 +1933,6 @@ import { A, B } from 'foo';
 type T = A;
 const b = B;
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       options: [{ prefer: 'no-type-imports' }],
       errors: [
         {
@@ -1962,9 +1953,6 @@ import { B, type C } from 'foo';
 type T = A | C;
 const b = B;
       `,
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       options: [{ prefer: 'type-imports' }],
       errors: [
         {

diff --git a/packages/eslint-plugin/tests/rules/member-ordering.test.ts b/packages/eslint-plugin/tests/rules/member-ordering.test.ts
@@ -30,9 +30,6 @@ interface Foo {
 }
     `,
     {
-      dependencyConstraints: {
-        typescript: '4.5',
-      },
       code: `
 // no accessibility === public
 interface Foo {
@@ -1313,9 +1310,6 @@ class Foo {
   f = 1;
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [{ default: ['static-initialization', 'method', 'field'] }],
     },
     {
@@ -1326,9 +1320,6 @@ class Foo {
   static {}
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [{ default: ['method', 'field', 'static-initialization'] }],
     },
     {
@@ -1339,9 +1330,6 @@ class Foo {
   m() {}
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [{ default: ['field', 'static-initialization', 'method'] }],
     },
     `
@@ -4675,9 +4663,6 @@ class Foo {
   f = 1;
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [{ default: ['method', 'field', 'static-initialization'] }],
       errors: [
         {
@@ -4708,9 +4693,6 @@ class Foo {
   static {}
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [{ default: ['static-initialization', 'method', 'field'] }],
       errors: [
         {
@@ -4732,9 +4714,6 @@ class Foo {
   m() {}
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [{ default: ['static-initialization', 'field', 'method'] }],
       errors: [
         {
@@ -4756,9 +4735,6 @@ class Foo {
   m() {}
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [{ default: ['field', 'static-initialization', 'method'] }],
       errors: [
         {
@@ -4782,9 +4758,6 @@ class Foo {
   md() {}
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [
         { default: ['decorated-method', 'static-initialization', 'method'] },
       ],

diff --git a/...tests/rules/member-ordering/member-ordering-alphabetically-case-insensitive-order.test.ts b/...tests/rules/member-ordering/member-ordering-alphabetically-case-insensitive-order.test.ts
@@ -500,9 +500,6 @@ class Foo {
   static {}
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [
         {
           default: {

diff --git a/...es/eslint-plugin/tests/rules/member-ordering/member-ordering-alphabetically-order.test.ts b/...es/eslint-plugin/tests/rules/member-ordering/member-ordering-alphabetically-order.test.ts
@@ -1695,9 +1695,6 @@ class Foo {
   static {}
 }
       `,
-      dependencyConstraints: {
-        typescript: '4.4',
-      },
       options: [
         {
           default: {