minor improvements

- naming of options - using nullish coalescing assignment
typescript-eslint · Aug 14, 2023 · 6ca18e1 · 6ca18e1
1 parent 7451956
commit 6ca18e1
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/eslint-plugin/src/rules/prefer-destructuring.ts b/packages/eslint-plugin/src/rules/prefer-destructuring.ts
@@ -88,11 +88,11 @@ export default createRule<Options, MessageIds>({
     },
     {},
   ],
-  create(context, [enabledTypes, options1 = {}]) {
+  create(context, [enabledTypes, options = {}]) {
     const {
       enforceForRenamedProperties = false,
       enforceForDeclarationWithTypeAnnotation = false,
-    } = options1;
+    } = options;
     const { program, esTreeNodeToTSNodeMap } = getParserServices(context);
     const typeChecker = program.getTypeChecker();
     const baseRules = baseRule.create(context);
@@ -173,9 +173,7 @@ export default createRule<Options, MessageIds>({
     }
 
     function baseRulesWithoutFix(): ReturnType<typeof baseRule.create> {
-      if (baseRulesWithoutFixCache == null) {
-        baseRulesWithoutFixCache = baseRule.create(noFixContext(context));
-      }
+      baseRulesWithoutFixCache ??= baseRule.create(noFixContext(context));
       return baseRulesWithoutFixCache;
     }
   },