feat(typescript-estree): throw error when CatchClause param contains …

…initializer (#8183)
typescript-eslint · Jan 4, 2024 · 544fd77 · 544fd77
1 parent ca00388
commit 544fd77
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 0 deletions.
diff --git a/packages/ast-spec/src/special/CatchClause/fixtures/_error_/with-initializer/fixture.ts b/packages/ast-spec/src/special/CatchClause/fixtures/_error_/with-initializer/fixture.ts
@@ -0,0 +1,4 @@
+try {
+}
+catch (e = 1) {
+}
diff --git a/...src/special/CatchClause/fixtures/_error_/with-initializer/snapshots/1-TSESTree-Error.shot b/...src/special/CatchClause/fixtures/_error_/with-initializer/snapshots/1-TSESTree-Error.shot
diff --git a/...ec/src/special/CatchClause/fixtures/_error_/with-initializer/snapshots/2-Babel-Error.shot b/...ec/src/special/CatchClause/fixtures/_error_/with-initializer/snapshots/2-Babel-Error.shot
diff --git a/...rc/special/CatchClause/fixtures/_error_/with-initializer/snapshots/3-Alignment-Error.shot b/...rc/special/CatchClause/fixtures/_error_/with-initializer/snapshots/3-Alignment-Error.shot
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -887,6 +887,12 @@ export class Converter {
         });
 
       case SyntaxKind.CatchClause:
+        if (node.variableDeclaration?.initializer) {
+          this.#throwError(
+            node.variableDeclaration.initializer,
+            'Catch clause variable cannot have an initializer.',
+          );
+        }
         return this.createNode<TSESTree.CatchClause>(node, {
           type: AST_NODE_TYPES.CatchClause,
           param: node.variableDeclaration