fix(typescript-estree): forbid override on non-constructor function…

…/methods (#6729)
typescript-eslint · Mar 21, 2023 · 2f3638f · 2f3638f
1 parent d04e256
commit 2f3638f
Show file tree

Hide file tree

Showing 9 changed files with 36 additions and 1 deletion.
diff --git a/...src/parameter/TSParameterProperty/fixtures/_error_/override-function-parameter/fixture.ts b/...src/parameter/TSParameterProperty/fixtures/_error_/override-function-parameter/fixture.ts
@@ -0,0 +1 @@
+function foo(override parameter) {}
diff --git a/...eterProperty/fixtures/_error_/override-function-parameter/snapshots/1-TSESTree-Error.shot b/...eterProperty/fixtures/_error_/override-function-parameter/snapshots/1-TSESTree-Error.shot
diff --git a/...rameterProperty/fixtures/_error_/override-function-parameter/snapshots/2-Babel-Error.shot b/...rameterProperty/fixtures/_error_/override-function-parameter/snapshots/2-Babel-Error.shot
diff --git a/...terProperty/fixtures/_error_/override-function-parameter/snapshots/3-Alignment-Error.shot b/...terProperty/fixtures/_error_/override-function-parameter/snapshots/3-Alignment-Error.shot
diff --git a/...c/src/parameter/TSParameterProperty/fixtures/_error_/override-method-parameter/fixture.ts b/...c/src/parameter/TSParameterProperty/fixtures/_error_/override-method-parameter/fixture.ts
@@ -0,0 +1,3 @@
+class Foo {
+  method(override parameter) {}
+}
diff --git a/...ameterProperty/fixtures/_error_/override-method-parameter/snapshots/1-TSESTree-Error.shot b/...ameterProperty/fixtures/_error_/override-method-parameter/snapshots/1-TSESTree-Error.shot
diff --git a/...ParameterProperty/fixtures/_error_/override-method-parameter/snapshots/2-Babel-Error.shot b/...ParameterProperty/fixtures/_error_/override-method-parameter/snapshots/2-Babel-Error.shot
diff --git a/...meterProperty/fixtures/_error_/override-method-parameter/snapshots/3-Alignment-Error.shot b/...meterProperty/fixtures/_error_/override-method-parameter/snapshots/3-Alignment-Error.shot
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -3278,7 +3278,8 @@ export class Converter {
         (modifier.kind === SyntaxKind.PublicKeyword ||
           modifier.kind === SyntaxKind.PrivateKeyword ||
           modifier.kind === SyntaxKind.ProtectedKeyword ||
-          modifier.kind === SyntaxKind.ReadonlyKeyword)
+          modifier.kind === SyntaxKind.ReadonlyKeyword ||
+          modifier.kind === SyntaxKind.OverrideKeyword)
       ) {
         const func = getContainingFunction(node)!;