feat(typescript-estree): throw on invalid update expressions (#7202)

* feat(typescript-estree): throw on invalid update expressions * Test parens * Handle optional chain + assertion * Update packages/typescript-estree/src/convert.ts Co-authored-by: fisker Cheung <lionkay@gmail.com> * Update snapshot * Add test cases, add satisfies & as * Fix fixtures? * Fix? * Fix tests --------- Co-authored-by: fisker Cheung <lionkay@gmail.com> Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
typescript-eslint · Jan 4, 2024 · 1a8e0dc · 1a8e0dc
1 parent e566a5d
commit 1a8e0dc
Show file tree

Hide file tree

Showing 41 changed files with 5,243 additions and 37 deletions.
diff --git a/packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/call-expr/fixture.ts b/packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/call-expr/fixture.ts
@@ -0,0 +1 @@
+a()++;
diff --git a/...rc/expression/UpdateExpression/fixtures/_error_/call-expr/snapshots/1-TSESTree-Error.shot b/...rc/expression/UpdateExpression/fixtures/_error_/call-expr/snapshots/1-TSESTree-Error.shot
diff --git a/...c/src/expression/UpdateExpression/fixtures/_error_/call-expr/snapshots/2-Babel-Error.shot b/...c/src/expression/UpdateExpression/fixtures/_error_/call-expr/snapshots/2-Babel-Error.shot
diff --git a/...c/expression/UpdateExpression/fixtures/_error_/call-expr/snapshots/3-Alignment-Error.shot b/...c/expression/UpdateExpression/fixtures/_error_/call-expr/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/literal/fixture.ts b/packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/literal/fixture.ts
@@ -0,0 +1 @@
+1++;
diff --git a/.../src/expression/UpdateExpression/fixtures/_error_/literal/snapshots/1-TSESTree-Error.shot b/.../src/expression/UpdateExpression/fixtures/_error_/literal/snapshots/1-TSESTree-Error.shot
diff --git a/...pec/src/expression/UpdateExpression/fixtures/_error_/literal/snapshots/2-Babel-Error.shot b/...pec/src/expression/UpdateExpression/fixtures/_error_/literal/snapshots/2-Babel-Error.shot
diff --git a/...src/expression/UpdateExpression/fixtures/_error_/literal/snapshots/3-Alignment-Error.shot b/...src/expression/UpdateExpression/fixtures/_error_/literal/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/optional-chain/fixture.ts b/packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/optional-chain/fixture.ts
@@ -0,0 +1 @@
+x?.y++;
diff --git a/...pression/UpdateExpression/fixtures/_error_/optional-chain/snapshots/1-TSESTree-Error.shot b/...pression/UpdateExpression/fixtures/_error_/optional-chain/snapshots/1-TSESTree-Error.shot
diff --git a/.../expression/UpdateExpression/fixtures/_error_/optional-chain/snapshots/2-Babel-Error.shot b/.../expression/UpdateExpression/fixtures/_error_/optional-chain/snapshots/2-Babel-Error.shot
diff --git a/...ression/UpdateExpression/fixtures/_error_/optional-chain/snapshots/3-Alignment-Error.shot b/...ression/UpdateExpression/fixtures/_error_/optional-chain/snapshots/3-Alignment-Error.shot
diff --git a/...ages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/optional-chain2/fixture.ts b/...ages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/optional-chain2/fixture.ts
@@ -0,0 +1 @@
+x?.y.z++;
diff --git a/...ression/UpdateExpression/fixtures/_error_/optional-chain2/snapshots/1-TSESTree-Error.shot b/...ression/UpdateExpression/fixtures/_error_/optional-chain2/snapshots/1-TSESTree-Error.shot
diff --git a/...expression/UpdateExpression/fixtures/_error_/optional-chain2/snapshots/2-Babel-Error.shot b/...expression/UpdateExpression/fixtures/_error_/optional-chain2/snapshots/2-Babel-Error.shot
diff --git a/...ession/UpdateExpression/fixtures/_error_/optional-chain2/snapshots/3-Alignment-Error.shot b/...ession/UpdateExpression/fixtures/_error_/optional-chain2/snapshots/3-Alignment-Error.shot
diff --git a/...ages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/optional-chain3/fixture.ts b/...ages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/optional-chain3/fixture.ts
@@ -0,0 +1 @@
+x?.y().z++;
diff --git a/...ression/UpdateExpression/fixtures/_error_/optional-chain3/snapshots/1-TSESTree-Error.shot b/...ression/UpdateExpression/fixtures/_error_/optional-chain3/snapshots/1-TSESTree-Error.shot
diff --git a/...expression/UpdateExpression/fixtures/_error_/optional-chain3/snapshots/2-Babel-Error.shot b/...expression/UpdateExpression/fixtures/_error_/optional-chain3/snapshots/2-Babel-Error.shot
diff --git a/...ession/UpdateExpression/fixtures/_error_/optional-chain3/snapshots/3-Alignment-Error.shot b/...ession/UpdateExpression/fixtures/_error_/optional-chain3/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/paren-expr/fixture.ts b/packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/paren-expr/fixture.ts
@@ -0,0 +1 @@
+(a())++;
diff --git a/...c/expression/UpdateExpression/fixtures/_error_/paren-expr/snapshots/1-TSESTree-Error.shot b/...c/expression/UpdateExpression/fixtures/_error_/paren-expr/snapshots/1-TSESTree-Error.shot
diff --git a/.../src/expression/UpdateExpression/fixtures/_error_/paren-expr/snapshots/2-Babel-Error.shot b/.../src/expression/UpdateExpression/fixtures/_error_/paren-expr/snapshots/2-Babel-Error.shot
diff --git a/.../expression/UpdateExpression/fixtures/_error_/paren-expr/snapshots/3-Alignment-Error.shot b/.../expression/UpdateExpression/fixtures/_error_/paren-expr/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/expression/UpdateExpression/fixtures/valid-assignment/fixture.ts b/packages/ast-spec/src/expression/UpdateExpression/fixtures/valid-assignment/fixture.ts
@@ -0,0 +1,15 @@
+class F {
+  #a;
+
+  m() {
+    this.#a++;
+    this.m().a++;
+    this[1] = 1;
+    F++;
+    // prettier-ignore
+    (this.#a)++;
+    (<number>this.#a)++;
+    (this.#a satisfies number)++;
+    (this.#a as number)++;
+  }
+}