Add ReactNode type docs #627
Conversation
docs/react-types/ReactNode.md
Outdated
| } | ||
|
|
||
| function Component({ children }: Props) { | ||
| return <>{children}</>; |
There was a problem hiding this comment.
| return <>{children}</>; | |
| return children; |
Latest types and TS will support that and that's the proper default. Everything else are workarounds for bugs. We have those documented I think somewhere and should link to it.
There was a problem hiding this comment.
Definitely should be the default. The problem I get (with latest @types/react and typescript) is that <Component> implicitly gets ReactNode as return type, which gives type error when I try to render <Component> from another component:
import { ReactNode } from "react";
interface Props {
children?: ReactNode;
}
function Component({ children }: Props) {
return children;
}
function Example() {
return <Component>Hello</Component>; // 'Component' cannot be used as a JSX component. Its return type 'ReactNode' is not a valid JSX element.
}Should this not produce a type error in latest @types/react and typescript?
There was a problem hiding this comment.
Will be fixed either today or tomorrow: microsoft/TypeScript#53031 (comment) + DefinitelyTyped/DefinitelyTyped#65135
There was a problem hiding this comment.
And now the TypeScript playground I linked just magically works. Amazing! Do you think we need to inform what version are required for this or should we should assume latest (as we actually state we do)?
No description provided.