feat: target es2019 in our tsconfig #7967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this enables a number of features that tsconfig can use when compiling to javascript - including native promises and `Array.includes()`. however, this does limit us to node 12+
imnotjames
force-pushed
the
feat/7223/target-es2019
branch
from
8dd3412
to
4413f8b
Compare
imnotjames
force-pushed
the
feat/7223/target-es2019
branch
from
bc58f94
to
03d23c6
Compare
7 tasks
Ginden
reviewed
Nov 19, 2021
| @@ -1,10 +1,10 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "lib": ["es5", "es6"], | |||
| "lib": ["es2020"], | |||
There was a problem hiding this comment.
Commit message says "2019", but it's "2020" here.
|
Was merged into #8616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
this enables a number of features that tsconfig can use
when compiling to javascript - including native promises
and
Array.includes(). however, this does limit us tonode 12+
target:es2019- Node 12+ supports syntaxlib:es2020- Node 12+ supports the standard libraryfixes #7223
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000