Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12078 log regression #12079

Merged
merged 3 commits into from
Jan 12, 2024
Merged

12078 log regression #12079

merged 3 commits into from
Jan 12, 2024

Conversation

glyph
Copy link
Member

@glyph glyph commented Jan 12, 2024

Scope and purpose

Fixes #12078

@glyph
Copy link
Member Author

glyph commented Jan 12, 2024

This is blocked by #12076 , as everything currently is

@glyph
Copy link
Member Author

glyph commented Jan 12, 2024

please review

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

@glyph glyph enabled auto-merge January 12, 2024 18:11
@glyph glyph merged commit fec0878 into trunk Jan 12, 2024
23 checks passed
@glyph glyph deleted the 12078-log-regression branch January 12, 2024 18:44
@adiroiban
Copy link
Member

I manually retried the macos test ... it was failing at twisted.internet.test.test_fdset.ReactorFDSetTestsBuilder_CFReactorTests.test_addWriter due to #12029

@glyph
Copy link
Member Author

glyph commented Jan 12, 2024

I manually retried the macos test ... it was failing at twisted.internet.test.test_fdset.ReactorFDSetTestsBuilder_CFReactorTests.test_addWriter due to #12029

Thanks. Really need to get around to fixing that intermittent bug, it's annoying 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging regression
3 participants