fix trunk failing build by pinning PyPy to 3.7.13, as 3.7.14 is failing currently, and add some type annotations to deal with new annotations in pyOpenSSL #12077
Conversation
|
please review |
There was a problem hiding this comment.
Looks good. Thanks.
I don't know why the iocp reactor code is not reported as coverted by automated test.
We run the whole test suite on Windows with iocp reactor and coverage enabled.
But this can be looked into a separate PR.
The important part is to fix trunk.
@glyph if you have time to review, I can work on the mypy upgrade.
Regards
| tox-env: 'alldeps-nocov-posix' | ||
| job-name: 'no-coverage' | ||
| skip-coverage: yes | ||
|
|
||
| # We still run some tests with coverage, | ||
| # as there are test with specific code branches for pypy. | ||
| - python-version: 'pypy-3.9' | ||
| - python-version: 'pypy3.10-v7.3.13' |
There was a problem hiding this comment.
Maybe mention in the releas notes that PyPy3.9 is no longer supported, and we now support PyPy 3.10?
There was a problem hiding this comment.
The interesting thing that is happening here is that we are not supporting the latest PyPy, 7.3.14; 7.3.13 works with both 3.9 and 3.10, and the CPython coverage for syntax differences seems sufficient, given that those two "versions" are substantially similar. So I wouldn't say it's unsupported, and if we have PyPy-3.9 specific issues we could add another buildbot. I bumped the Python version since if we are going to make space in the test matrix, it seems like 3.10 would probably be more used at this point than 3.9.
|
Instead of "hopefully fix trunk" maybe the title of this PR should be "Use PyPy 3.10 in testing to fix CI failures caused by latest changes to PyPy 3.9." |
glyph
changed the title
It must be a codecov bug. Note that the codecov status check says that codecov/patch hits 100% of the diff target, and some of the changed lines are in those files, so it's not even self-consistent. |
Fixes #12076