-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chat.py example #12070
Merged
Merged
Fix chat.py example #12070
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1206d79
Fix chat.py example
ReneNyffenegger c59c93e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9e093f5
Add release notes
adiroiban 130ffb7
Merge branch 'trunk' into fix-chat-example
glyph 9fb1257
Merge branch 'trunk' into fix-chat-example
adiroiban d05599b
Merge branch 'trunk' into fix-chat-example
adiroiban File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
The documented IRC example was updated for Python3 usage. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment to avoid all the encode + decode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree with this comment but I think
is correct to avoid
TypeError
.Is there any reason for that we didn't applied it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for the feedback. This was merged as it was better than what we had in
trunk
. There is alwasy place for improvement :)Feel free to open a new GitHub Issue and PR if you would like to see this change merged.
The IRC implementation in Twisted needs some love and I would be happy to see people care about this code :)
Cheer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @adiroiban, I've created an issue and a pr for it.