#12056 Update dis.findlinestarts for Python 3.13 #12059
Conversation
adiroiban
changed the title
|
This is ready for review, but before reviewing this, please take a look at #12058 Once we remove the cgi dependency, we can "unlock" many more tests on Python 3.13 needs-review |
| @@ -0,0 +1 @@ | |||
| Update `int` and `None` comparisons as required by Python 3.13. | |||
There was a problem hiding this comment.
Seems like a minor change. As a user, what would this mean to me? Just some internal implementation details. "Support Python 3.13" will be a more interesting news fragment, when we get there. :)
There was a problem hiding this comment.
True. Thanks. This info is wrong.
The change is in the way we use the result of findlinesstarts as mentioned in the title of this pr.
I converted this to a misc.
|
I can confirm that using this patch on our attempted build for Fedora Linux makes all of the failures with |
| tox-env: 'mindeps-nocov-posix' | ||
| job-name: 'mindeps-nocov-3.13' | ||
| skip-coverage: yes | ||
| # FIXME:https://github.com/twisted/twisted/issues/12060 |
There was a problem hiding this comment.
I can confirm that this change works with my changes in #12061, allowing tests in twisted.internet to pass on Python 3.13 (excluding those that require cffi and other yet-unsupported dependencies).
|
Thanks for your reviews. @exarkun I have updated the release notes and automated tests so that we can have part of the curren test running on 3.13. Do you have time to take another look at this? With future PRs we can enable more tests. I think is important to have this merged as the base for future py3 changes. |
|
Many thanks for your reviews. I have merged this. |
Scope and purpose
Fixes #12056
This updates the usage of dis.findlinestarts.
The Python 3.13 tests are cherry picked to be executed.
Later we can enable more.
As a drive-by, update GitHub Actions Python helper to the latest version.